? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
2 Nov 2016

Pull Request for Issue #12692.

Summary of Changes

Shows only fields in the form on the back end for published groups.

Testing Instructions

  • Create a Field Group for Articles.
  • Create a Field and assign it to that group
  • Unpublish the Field Group.

Expected result

The field should not be proposed in the edit form as its Group is unpublished.

Actual result

The field is still proposed under the tab of its Field Group when editing an article.

avatar laoneo laoneo - open - 2 Nov 2016
avatar laoneo laoneo - change - 2 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Category Administration Components
avatar laoneo laoneo - change - 2 Nov 2016
Title
Include group state only when not on back end list
[com_fields] Include group state only when not on back end list
avatar laoneo laoneo - change - 2 Nov 2016
Title
Include group state only when not on back end list
[com_fields] Include group state only when not on back end list
avatar laoneo laoneo - edited - 2 Nov 2016
avatar infograf768
infograf768 - comment - 2 Nov 2016

Tested successfully (I had again problems with SHA @mbabker )

avatar brianteeman
brianteeman - comment - 2 Nov 2016

@infograf768 - again - clear your browser cache

On 2 November 2016 at 16:37, infograf768 notifications@github.com wrote:

Tested successfully (I had again problems with SHA @mbabker
https://github.com/mbabker )


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12696 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZZWatY5hgeW0LJNZYwkSP9C11YKks5q6LxjgaJpZM4KnGQj
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2016
Category Administration Components Administration com_fields Components
avatar Bakual
Bakual - comment - 7 Dec 2016

Can you maybe add a comment as to why we even have that check? Because it confused me as well.
Now I think it's just so we still see the fields in the fields manager, right?

avatar laoneo
laoneo - comment - 7 Dec 2016

Yes, it considers the group state only on the front. We never consider the group state on the back end for lists.

avatar Bakual
Bakual - comment - 7 Dec 2016

Agreed. Can you add a comment to it? Because I don't think we have that case anywhere else (usually we have different models in front- and backend).

avatar brianteeman
brianteeman - comment - 7 Dec 2016

I have tested this item successfully on c9b6f4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696.

avatar brianteeman brianteeman - test_item - 7 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 8 Dec 2016

Comment added

avatar brianteeman brianteeman - change - 8 Dec 2016
Easy No Yes
avatar brianteeman
brianteeman - comment - 8 Dec 2016

I have tested this item successfully on f4c413c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696.

avatar brianteeman brianteeman - test_item - 8 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 14 Dec 2016

We have here two successful tests, can be set to RTC.

avatar Bakual
Bakual - comment - 14 Dec 2016

Lets just merge it instead :)

avatar Bakual Bakual - reference | bf6693b - 14 Dec 16
avatar Bakual Bakual - merge - 14 Dec 2016
avatar Bakual Bakual - close - 14 Dec 2016
avatar Bakual Bakual - change - 14 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-14 07:25:40
Closed_By Bakual
avatar Bakual Bakual - close - 14 Dec 2016
avatar Bakual Bakual - merge - 14 Dec 2016
avatar Bakual Bakual - change - 14 Dec 2016
Milestone Added:
avatar laoneo laoneo - head_ref_deleted - 14 Dec 2016
avatar laoneo
laoneo - comment - 14 Dec 2016

Even better. Thanks.

avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment