@alikon this just includes the update part is that correct / expected?

Also this is all in one line? is this expected too?

No, I'm having big connection issues, hope to solve soon i'll put install
file too, sorry...

On 31 Oct 2016 3:15 pm, "zero-24" notifications@github.com wrote:

@alikon https://github.com/alikon this jjust includes the update part
is that correct / expected?

Also this is all in one line? is this expected too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12660 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFseYWgpypxgDH7RwRdfDNjlLpPyDyks5q5fgQgaJpZM4KlDXf
.

no problem. Thanks!

@alikon can you please add line endings

@andrepereiradasilva I'll complete this pr when I regain a stable
connection ;)

On 31 Oct 2016 3:57 pm, "andrepereiradasilva" notifications@github.com
wrote:

@alikon https://github.com/alikon can you please add line endings

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12660 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsVWAyEckp3pUJLs7zA2hYZ04JP4wks5q5f2vgaJpZM4KlDXf
.

can someone do a review or a test on MSSQL (cause i don't have a mssql environment available)

Had a discussion with @matrikular about the MSSQL scripts. Perhaps he can test it as well.

updated for #13091

Can you add the "[com_fields]" to the beginning of the title? People start asking about open pull requests and I'm telling them that they have to search for com_fields. Thanks.

Adjusted the title

updated for #13115

There is a missing comma at the end of this line
[language] nvarchar NOT NULL DEFAULT ''
in both files.

With this change installation and update went fine.

I also applied #13115 but when creating a new fields group I get this sql error:

Microsoft][SQL Server Native Client 11.0][SQL Server]No column name was specified for column 1 of 'A'. SQL=SELECT * FROM ( SELECT count(id) , ROW_NUMBER() OVER (ORDER BY (select 0)) AS RowNumber FROM #__usergroups) A WHERE A.RowNumber BETWEEN 1 AND 1

But this is something for another patch, right?

@waader thank you very much for testing. @alikon can you update the code please?

thanks @waader for testing, and yes please open a new issue for that

Installation works now but at Extensions > Manage > Database you will find:

Table 'tf7qr_fields( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'tf7qr_fields_groups( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'tf7qr_fields_values( field_id' does not exist. (From file 3.7.0-2016-08-29.sql.)

When updating an older joomla version you will find the same messages but also an error that indicates that com_fields could not be loaded.

A Click on Discover shows this error:
515 [Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla35.dbo.#__extensions'; column does not allow nulls. INSERT fails. SQL=INSERT INTO [#__extensions] ([name],[type],[element],[folder],[client_id],[access],[manifest_cache],[params],[state]) VALUES ('com_fields','component','com_fields','','1','1','{"name":"com_fields","type":"component","creationDate":"March 2016","author":"Joomla! Project","copyright":"(C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"www.joomla.org","version":"DEPLOY_VERSION","description":"COM_FIELDS_XML_DESCRIPTION","group":"","filename":"fields"}','{}','-1')

I suspect that this is unrelated from com_fields, can you can confirm discovering another extension

I have tested this item ✅ successfully on db9cce5

@alikon: you are right. Has nothing to do with your patch. Thanks!

I guess this one here can be merged as it is unlikely we will find another person who is testing it on MSSQL.

Actually, if you spin up Ubuntu 16.04 you can run SQL Server from there now. https://www.microsoft.com/en-us/sql-server/developer-get-started/php-ubuntu

Same with Red Hat - https://www.microsoft.com/en-us/sql-server/developer-get-started/php-rhel

If I find someone to move my Crowdin scripts from my private server to Joomla property, I would be happy to spin up a new server and try that out :)

updated for #13175

@alikon you are fast. Just wanted to write a notice, that the structure of com_fields changed again and saw that you did it already ? . Good work.

updated for #13246

I have tested it on backend and it is OK.

Why there is a few difference between sql install and update file?

The install and update file need to be equal as we need everything (tables etc.) also on sites that got updated to 3.7.0 :)

fixed the missed default

After I patched by Patch Tester a see (it is incorrect - table name should not contain column name):

Table 'j37_fields( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_categories(  field_id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_groups( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_values( field_id' does not exist. (From file 3.7.0-2016-08-29.sql.)

After I click FIX the tables are created and fields work OK.

But I still see above warnings.

Please add white space before '(':

CREATE TABLE [#__fields](

replace to:

CREATE TABLE [#__fields] (

and for others "CREATE TABLE" do the same.

@csthomas added the space, but all other existing CREATE TABLE don't have that space
anyway thanks for testing

I have tested this item ✅ successfully on 6fad1a2

Because of some regex in database fix in component installer "CREATE TABLE" requires space.
It is only needed in update sql files:)

Success.

Database schema version (in #__schemas): 3.7.0-2016-11-24.
Update version (in #__extensions): 3.7.0-alpha2.
Database driver: sqlsrv.
12 database changes were checked successfully.
225 database changes did not alter table structure and were skipped.

Because the last two commits add only white spaces and " DEFAULT ''" which exists in the install sql file
IMO it can be merged without additional test.

Because of some regex in database fix in component installer "CREATE TABLE" requires space.
It is only needed in update sql files

we need to remeber this when we will update some others on MSSQL

Can a maintainer set this to RTC as we have a successful test on MSSQL.

There will be some more work then when pr #13319 got merged. But let's get this one in first.

We have only one test as #12660 (comment) was done before changes

Honestly I'm not sure if we will find two testers for this.

I will test this one later today.

thanks @waader

I have tested this item ✅ successfully on 6fad1a2

I tested the backend with content, users and contacts and it works. Frontend is currently broken which has nothing to do with this patch. With a rudimentary fix I could get it working also in frontend.

You can try to test front end with applied #13262

I also did that, but it didn´t work.

Thanks for all the work guys!! Ready for RTC.

RTC