? Success

User tests: Successful: Unsuccessful:

avatar nvyush
nvyush
31 Oct 2016

Summary of Changes

Normalize some parameters in com_contact and com_content xml files (some parameters was missing in some xml, see below).
Reorder parameters as they shown in views.
Code style (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md).

/administrator/components/com_contact/config.xml - added show_category_heading_title_text parameter, reordered parameters of category, categories, list_default_parameters fieldsets, code style.
/components/com_contact/views/categories/tmpl/default.xml - added show_category_heading_title_text, show_image_heading, initial_sort parameters, reordered parameters of basic, category, advanced fieldsets, code style.
/components/com_contact/views/category/tmpl/default.xml - added show_category_heading_title_text parameter, reordered parameters of category fieldset, code style.

/administrator/components/com_content/config.xml - fixed double names of spacers, reordered parameters of category, categories, list_default_parameters fieldsets, code style.
/components/com_content/views/categories/tmpl/default.xml - added show_category_heading_title_text, show_cat_tags, page_subheading parameters, reordered parameters of basic, category, advanced fieldsets, code style.
/components/com_content/views/category/tmpl/blog.xml - reordered parameters of category fieldset, code style.
/components/com_content/views/category/tmpl/default.xml - removed unnecessary >, reordered parameters of category fieldset, code style.

Testing Instructions

  1. Use a fresh Joomla install with sample items.
  2. Create a tree of some contact categories.
  3. Create contacts with default options and place they to some contact categories.
  4. Create menu items of the types Contacts » List All Contact Categories and Contacts » List Contacts in a Category for the root contact category.
  5. Check the contact categories in the frontend. All should be fine.
  6. Play with option 'Show Subcategories Text' in Global Configuration » Contacts, in the Category tab of the menu items you created and check everything is fine.

The same for content (menutypes: Articles » List All Categories, Articles » Category List, Articles » Category Blog)

avatar nvyush nvyush - open - 31 Oct 2016
avatar nvyush nvyush - change - 31 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Category Administration Components Front End
avatar nvyush
nvyush - comment - 1 Nov 2016

UPD: When testing List All Categories menu item other menu items must be unpublished

avatar jeckodevelopment
jeckodevelopment - comment - 5 Nov 2016

@nvyush can you please look at the conflicts?

Conflicting files

components/com_content/views/categories/tmpl/default.xml
components/com_content/views/category/tmpl/blog.xml
components/com_content/views/category/tmpl/default.xml
avatar nvyush
nvyush - comment - 9 Nov 2016

Closed as this PR conflicted with PR #11911.
New PR is #12846.

avatar nvyush nvyush - close - 9 Nov 2016
avatar nvyush nvyush - head_ref_deleted - 9 Nov 2016
avatar nvyush
nvyush - comment - 9 Nov 2016

@jeckodevelopment I made somthing wrong when updated my fork so PR #12846 contains a lot of unnecessary commits. What can I do? Or leave as is?

avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

@nvyush i saw you closed it.

avatar nvyush
nvyush - comment - 9 Nov 2016

@jeckodevelopment I close this PR #12661. My question is about PR #12846 - is it OK?

avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

yes, i got you were talking about #12846 , it's closed.

avatar nvyush
nvyush - comment - 9 Nov 2016

@jeckodevelopment PR #12846 is not closed, it contains reference to closed PR #12661. I saw, you locked it.
How can I save my job?

avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

Unlocked it again.
I'm sorry i misunderstood the other PR and i wrongly saw it as closed.
Excuse me!

Add a Comment

Login with GitHub to post a comment