I am trying to solve the most obvious issues in com_fields. See PRs.
There are 2 aspects I do not understand;
I guess, before we go on patching, that we need replies on these matters.
Labels |
Added:
?
|
it's not so strange that people have question now after merge
better late than never
@laoneo This was merged real fast and I had not looked at it before (we have hundreds of PR, the most important to me being bugs and language matters).
In any case. I do NOT see the use of language, even for fields, not only field groups/categories.
Concerning the modals, here is your component tree:
It looks to me that it is a sort of copy/paste from other components as I could not find where these modals are used (some using forcedlanguage which is ONLY used in multiligual sites with specific calls).
just another 'strange' question
can you clarify the usefulness of this two fields on #__fields
table
The field has a language parameter, because when an article belongs to a language, then only fields are displayed which do belong to the same language.
@alikon this can be removed, they come indeed from com_categories. In an earlier version of com_fields, I had the version part working but it broke somehow during development more information can be found here joomla-projects/custom-fields#54.
@infograf768 I guess the modals can be removed as well.
The field has a language parameter, because when an article has belongs to a language, then only fields are displayed which do belong to the same language.
Where is the code for this please?
Here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/helpers/fields.php#L86. But would be great if you can test it as well as I was the only one who tested that functionality I guess.
Also, if the language is changed, the custom Field still displays.
We need some ajax magic here.
It is really hard with ajax. What I did when the category of an article is changed to reloaded the page, doing the same when the language is changed would be the safest option.
OK, let's do things one after another
Can you make a PR to take care of
1. modals
2. version, hits
3. use if (JLanguageMultilang::isEnabled())
and then we will go on
Done. Can you please change the title of the issue to something more meaningful. Thanks for testing hard com_fields.
I can close it if you like.
remains the categories associations issue
Any clue how to fix that one?
I have a PR. Will post asap.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-01 11:25:19 |
Closed_By | ⇒ | infograf768 |
Feeling a bit strange that you post these questions after we merged it into staging after 9 months of development time in it's own repository. Should probably have done better marketing that more people would recognize that we are planing to integrate DPFields into core.?