?
avatar infograf768
infograf768
31 Oct 2016

@laoneo

I am trying to solve the most obvious issues in com_fields. See PRs.
There are 2 aspects I do not understand;

  1. language Why do you even care for languages concerning fields? What is its use and did you know that on a multingual site Field Groups (as they are de facto Categories) can be associated which is, at what I see, totally useless.

screen shot 2016-10-31 at 14 36 09

  1. Modals You have created modal templates and I see no use for them.

I guess, before we go on patching, that we need replies on these matters.

avatar infograf768 infograf768 - open - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar laoneo
laoneo - comment - 1 Nov 2016
  1. Language The association is not needed for groups, is there a way to hide them as there are basically com_categories.
  2. What for modal templates are you talking about. Please post a screenshot or a link to the source file that I can properly answer your question.

Feeling a bit strange that you post these questions after we merged it into staging after 9 months of development time in it's own repository. Should probably have done better marketing that more people would recognize that we are planing to integrate DPFields into core. ?

avatar alikon
alikon - comment - 1 Nov 2016

it's not so strange that people have question now after merge

better late than never

avatar infograf768
infograf768 - comment - 1 Nov 2016

@laoneo This was merged real fast and I had not looked at it before (we have hundreds of PR, the most important to me being bugs and language matters).

In any case. I do NOT see the use of language, even for fields, not only field groups/categories.

Concerning the modals, here is your component tree:
screen shot 2016-11-01 at 08 22 13
It looks to me that it is a sort of copy/paste from other components as I could not find where these modals are used (some using forcedlanguage which is ONLY used in multiligual sites with specific calls).

avatar alikon
alikon - comment - 1 Nov 2016

just another 'strange' question

can you clarify the usefulness of this two fields on #__fields table

  • version
  • hits
avatar infograf768
infograf768 - comment - 1 Nov 2016

@laoneo
Also, please look at
#12656

We have to allow translation of the label, the description, the hint if desired

avatar laoneo
laoneo - comment - 1 Nov 2016

The field has a language parameter, because when an article belongs to a language, then only fields are displayed which do belong to the same language.

@alikon this can be removed, they come indeed from com_categories. In an earlier version of com_fields, I had the version part working but it broke somehow during development more information can be found here joomla-projects/custom-fields#54.

avatar laoneo
laoneo - comment - 1 Nov 2016

@infograf768 I guess the modals can be removed as well.

avatar infograf768
infograf768 - comment - 1 Nov 2016

The field has a language parameter, because when an article has belongs to a language, then only fields are displayed which do belong to the same language.

Where is the code for this please?

avatar laoneo
laoneo - comment - 1 Nov 2016

Here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/helpers/fields.php#L86. But would be great if you can test it as well as I was the only one who tested that functionality I guess.

avatar infograf768
infograf768 - comment - 1 Nov 2016

@laoneo
It works, once the language is set for the article (did not test for users or contacts.
Nevertheless, this should ONLY work when the site is multingual, i.e. you should add a conditional
if (JLanguageMultilang::isEnabled())

avatar infograf768
infograf768 - comment - 1 Nov 2016

Also, if the language is changed, the custom Field still displays.
We need some ajax magic here.

avatar laoneo
laoneo - comment - 1 Nov 2016

It is really hard with ajax. What I did when the category of an article is changed to reloaded the page, doing the same when the language is changed would be the safest option.

avatar infograf768
infograf768 - comment - 1 Nov 2016

OK, let's do things one after another
Can you make a PR to take care of
1. modals
2. version, hits
3. use if (JLanguageMultilang::isEnabled())
and then we will go on

avatar laoneo
laoneo - comment - 1 Nov 2016

Done. Can you please change the title of the issue to something more meaningful. Thanks for testing hard com_fields.

avatar infograf768
infograf768 - comment - 1 Nov 2016

I can close it if you like.
remains the categories associations issue

avatar laoneo
laoneo - comment - 1 Nov 2016

Any clue how to fix that one?

avatar infograf768
infograf768 - comment - 1 Nov 2016

I have a PR. Will post asap.

avatar infograf768 infograf768 - change - 1 Nov 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-11-01 11:25:19
Closed_By infograf768
avatar infograf768 infograf768 - close - 1 Nov 2016
avatar infograf768
infograf768 - comment - 1 Nov 2016

See #12681

Will close this one.

Add a Comment

Login with GitHub to post a comment