Another limitation of our wonderfully broken admin menu system

On 31 October 2016 at 10:37, andrepereiradasilva notifications@github.com
wrote:

Steps to reproduce the issue

Use latest staging
Expected result

Contacts sidebar the same as contacts menu
Actual result

[image: image]
https://cloud.githubusercontent.com/assets/9630530/19851473/f6ddb4b2-9f55-11e6-86aa-63f1fe4e1bc6.png
System information (as much as possible)

Latest staging
Additional comments

None.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12658, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WWoECglcUTfuoB63UOvrzbGP7f_ks5q5cT_gaJpZM4Kk4J2
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

They are coming from here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_contact/helpers/contact.php#L42

More over, clicking on the Fields submenu item results in a 404 Component not found page. And when creating a new Field Group, the following errors:

Warning: Header may not contain more than a single header, new line detected in C:\dev\joomla-cms\libraries\joomla\application\web.php on line 947

1146 Table 'test.#__fields' doesn't exist SQL=SELECT state, count(*) AS count FROM #__fields WHERE catid = 78 GROUP BY state

I looked already at this issue. Submenu is not sidebar.
This submenu issue for contacts (Fields and Field Group DO show in the contacts sidebar) comes from the fact that even if we were forcing their display by declaring them in the contact xml, they should not show when com_fields is not enabled.

com_contact : sidebar

Let's first test and merge this first one who deals with the enabling:
#12646

@C-Lodder
To test com_fields, if you have not installed a brand new staging, you have to query in your db with
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.7.0-2016-08-29.sql

Everything in the components menu is database driven so without some wonky postprocessing you can't efficiently show/hide fields stuff there.

@mbabker
Yes, understood that (after some time...)
Therefore I think we have to deal with it, if this component is fully corrected and stays in core...

Yes, understood that (after some time...)

Sorry I should have been more explicit in my first post

Therefore I think we have to deal with it

Meaning?

Meaning,

as @mbabker said. We will not have fields and Field Groups submenus for 3rd party components, including contacts as we do not want them to display when the component is disabled.

without some wonky postprocessing

"wonky" is a strange word for me but it looks like "near impossible if one wants to do a clean job" ?

Basically you have to query the database, get the items for the menu, then while processing the menu somehow figure out a way to determine it is a fields related menu item and run the appropriate checks to decide to show/hide it. I don't have a database with fields menu items right now because I ran an install with sample data last night to be able to run tests for the joomla.org template with content and the admin menu stuff isn't in the sample data, so I don't have anything to look at quickly to say how clean or even efficient this might be.

ah - you meant "accept it"
In that context "deal with it" could also mean do something about it. The wonders of English.

It is possible to dynamically apply a menu item - several extensions do it

IF there is a way, then we should just add I guess the fields submenus for Contact in its xml and check for com_feeds enabled to display them or not.

Is it really incorrect? The Content -> Articles submenu doesnt match the sidebar either

it does match.

I guess you are using a different version of Joomla to me then ;)
The submenu for Articles has one entry - Add New Article
The sidebar has entries for categories, featured etc

i was indeed speaking only of the new menus fields, field groups as was stated in the description of the issue

I stand by what I said already - the submenu and the sidebar do not match
and do not have to match

We have several menu items that have sidebar items that are not in the menu

• it is nothing to do with com_fields

On 31 October 2016 at 17:06, infograf768 notifications@github.com wrote:

i was indeed speaking only of the new menus fields, field groups as was

stated in the description of the issue

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/tracker/
joomla-cms/12658.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12658 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VArvnjtp8UIoact5pJ1N874LXomks5q5iAUgaJpZM4Kk4J2
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

From a user experience point of view:
It were nice, com_fields would present its functionality always the same way, regardless of whether the component that "use" it is a core component or a third party component (as long as the com_fields component is enabled):

Actually menu structure:
Users > Fields
Users > Field Groups

Content > Fields
Content > Field Groups

But under "Components > Contacts" the "Fields" and "Field Groups" are missing.

My proposal menu structure for Contacts were:
Components > Contacts > Fields
Components > Contacts > Field Groups

This could be done the same way as it is done by com_users, com_content.

Update1: In my proposal the menu structure was wrong. It must be:
Components > Contacts >
I have changed it.

I disagree that it is required for all sidebar items to be present in the
top menu

Also you will note that for com_users and com_content they are 2nd level
items but for com_contact they would have to be third level

On 5 November 2016 at 13:25, beni71 notifications@github.com wrote:

From a user experience point of view:
It were nice, com_fields would present its functionality always the same
way, regardless of whether it is a core component or a third party (as long
as the component is enabled):

Actually menu structure:
Users > Fields
Users > Field Groups

Content > Fields
Content > Field Groups

But under "Components > Contacts" the "Fields" and "Field Groups" are
missing.

My proposal menu structure for Contacts were:
Components > Contact > Fields
Components > Contact > Field Groups

This could done the same way as it is done by com_users, com_content.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12658 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Z--dgZbYS_4iAVTpPlbw2sCd-EVks5q7IPHgaJpZM4Kk4J2
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

This is a power feature and personally I don't think it's needed as a sub menu of a component in the admin component. You may only use it at the initial build stage and would require ACL control as it's unlikely you would want to show fields to all users who are in the backend.

Is there any decisions made here?

The way the menu currently works, there is no sane way to add the fields menu items conditionally (depending on a parameter) to the menu. So we either show it always or never.

I guess it will become possible then, when pr #13036 get merged?

I haven't looked at it in detail, but from the description it would allow the Administrator to add/move/remove menu items like we have in frontend. It wouldn't allow (and shouldn't!) to conditionally enable/disable menu items from the structure.
Imho the whole parameter shouldn't exist (and is misleading anyway), but that's just my personal opinion.

@infograf768 can this being solved with the new back end menu system?

Can this be closed as it is not possible to do as @Bakual has stated and we do now have the custom admin menu ability if a user wants to create it for their own site @zero-24