? Success

User tests: Successful: Unsuccessful:

avatar fcoulter
fcoulter
31 Oct 2016

Pull Request for Issue #

Summary of Changes

update .htaccess to prevent url rewriting when the request is for an image file

Testing Instructions

on a test joomla site, try making a request for a non-existent image file eg http://mysite.com/images/none.jpg, you will see that the entire CMS is loaded.

Then make the change to the .htaccess and try again, you should see a server generated 404 page, which is as it should be

Documentation Changes Required

The problem is that if your site has missing images, with the current .htaccess for each missing image the request is redirected to the index.php where a 404 page is generated by the CMS. This is highly inefficient, this ought to be handled at the server level, which is what the change accomplishes.

I wrote an extended analysis here: https://www.spiralscripts.co.uk/Joomla-Tips/how-missing-images-can-damage-your-site.html

avatar fcoulter fcoulter - open - 31 Oct 2016
avatar fcoulter fcoulter - change - 31 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 31 Oct 2016

I dont believe your analysis on your blog post is correct

. Imagine if you have several missing images on your pages, then you can see that the problem can become substantial, because each one will generate a separate load of the CMS.
Yes if you enter a non existent image into the url address bar you will get the Joomla error page

If you have a non existent image in a web page then this is not the case and the server handles the 404. Please provide an example of where a missing image on a web page exhibits the behaviour you describe in your blog post

avatar fcoulter
fcoulter - comment - 31 Oct 2016

Actually Brian I think you are correct, I made a mistake during testing. I will close the pull request.

avatar fcoulter fcoulter - change - 31 Oct 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-10-31 10:53:45
Closed_By fcoulter
avatar fcoulter fcoulter - close - 31 Oct 2016
avatar fcoulter fcoulter - close - 31 Oct 2016
avatar brianteeman
brianteeman - comment - 31 Oct 2016

Probably a good idea to close your blog post as well

On 31 October 2016 at 10:53, Fiona Coulter notifications@github.com wrote:

Actually Brian I think you are correct, I made a mistake during testing. I
will close the pull request.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12657 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YZ1jbt5T-YwX4D8lBF-1aug0Kqzks5q5ci5gaJpZM4Kk3M0
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar fcoulter
fcoulter - comment - 31 Oct 2016

Well it may be useful sometimes. But I will add some claficiation. I originally wrote it because I was dealing with a site where this was an issue, and the modification to the .htaccess helped. I think this was because the site used a .htaccess inherited from Joomla 2.5 where I think this really was an issue. This was the source of my error, I was doing a lot of testing, had a lot of .htaccess files, and tested against the wrong one.

In Joomla 3 I think it is this line which already prevents the issue:

RewriteCond %{REQUEST_URI} /component/|(/[^.]*|.(php|html?|feed|pdf|vcf|raw))$

So no need for any modification.

My apologies for the confusion.

avatar brianteeman
brianteeman - comment - 31 Oct 2016

In Joomla 2.5 the behaviour is the same
See http://www.joomlatraining.org.uk/fiona as an example

RewriteCond %{REQUEST_URI} /component/|(/[^.]*|.(php|html?|feed|pdf|vcf|raw))$

That line does not exist in the Joomla htaccess file
https://github.com/joomla/joomla-cms/blob/staging/htaccess.txt

Of course its your choice if you want to gain a reputation for publishing false blog posts

avatar fcoulter
fcoulter - comment - 31 Oct 2016

Brian, I have already added a note in big letters to the post saying that is is an outdated article and does not apply to Joomla 3.

Since you seem to be determined to make a meal of something that was just an honest mistake, lets be clear, this is not about this issue at all, but my other blog post.

Apart from the rather click-baity headline, which I do regret now because it seems to have attracted a lot of attention from people who clearly could not be bothered to read the actual post, presumably because it was too much of a "wall of text", please point me to anything in the article which is incorrect? I will be happy to correct it. I was simply interested in how the vulnerability came about, which seems to be a legitimate question.

I find it ironic that I am being accused of discouraging people from contributing to open source projects, when I have been told to "f*ck off" by a member of the JSST for simply asking a question. Hardly encouraging open debate is it?

Grow up, the lot of you.

avatar brianteeman
brianteeman - comment - 31 Oct 2016

No I am only referring to this blog post and as I stated above it doesnt apply to Joomla 2.5 or Joomla 1.5 either.

I cannot comment on what someone else might have said about your other blog post. I can say that personally speaking I was very disappointed at that other blog post but that is not relevant.

I am sure that at the end of the day we all want the best for Joomla and the community and inaccurate and misleading blog posts dont help

avatar brianteeman
brianteeman - comment - 31 Oct 2016

Closing and locking this conversation as it is widely off the original topic

avatar brianteeman brianteeman - locked - 31 Oct 16

Add a Comment

Login with GitHub to post a comment