[#12516] - [4.0] Restructure Voting Plugin Integration
- Closed
- 7 Jan 2017
- Medium
- Build: 4.0-dev
- # 12516
- Diff
- mbabker:voting-all-in-plugin
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12331.
Summary of Changes
Move the voting integration for com_content to be completely within the plugin
- Parameters for the component config, article editor, and menu item views are all moved to the plugin and added via
onContentPrepareForm - The controller and model tasks to save the vote are moved into the plugin to be used with com_ajax
Testing Instructions
- With the voting plugin enabled, you should see voting parameters in all appropriate com_content screens; when disabled the parameters should be absent
- When voting is allowed, you should be able to vote on the item as before
- Voting responses are handled by AJAX
Documentation Changes Required
Document the removed methods from the component
TODO Items
- Remove join for voting data from models (I started to do this and move it to
onContentPreparebut this breaks the existingonContentBeforeDisplayevent) - Wire in the AJAX submission part of this (the PHP code is done, just need to write the JavaScript to handle it)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Components Language & Strings Front End Plugins |
A way to inject columns (th and td) in the views tables so we can add columns to views with a plugin. Is this possible now?
Hannes' wrote this JGrid class that conceivably could do it (the issue with it though is you're working more with objects than HTML in layouts).
| Labels |
Removed:
?
|
||
Query part was me messing stuff up. That's handled now. Just need to do the JavaScript.
how about the view templates trigger a plugin event on the end of TH and TD draw?
something like
-
onContentDrawTableTh($context) -
onContentDrawTableTd($context, $item)
Do we really want to trigger events at the end of every row? That seems very non-optimal (granted not being able to change the layouts isn't much better...).
hum ... anyway i guess we need a way to solve this.
Also, i guess solving this would be nice for extension developers.
this should be removed too, right? i think it's unused.
Also in 3.7.x there are some new opinions with vote that don't yet exists in 4.x branch
See here https://github.com/joomla/joomla-cms/pull/11225/files
That PR says to me that going this way with the integration is pretty much impossible (we lack events, rightfully so, for query manipulation in the models). The whole point of plugin behaviors is to make things optional and configurable; if we have stuff hardcoded into the component that seems like a function that can't be in a plugin.
i agree, but that PR was merged in 3.7.x some new options in the XML files that this new refactor you're doing imho should also have.
Well, considering the 4.0 branch is based on staging and not 3.7, it's hard to include stuff that doesn't exist in the base branch
eheh ok them
| Labels |
Added:
?
|
||
| Category | Administration Components Language & Strings Front End Plugins | ⇒ | Administration Components Language & Strings Front End JavaScript Plugins |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Removed:
?
|
||
Did the AJAX part of this. It's now running fully. Updated issue description with all relevant data.
Hi, if its not a trouble, wouldn't it be more flexible for user if we can have an option to create a template override for this plugin?
That's already a feature in 3.7.
Can you merge in staging here Michael :)
I have to make time to do a merge and figure out how to deal with the added features in 3.7 that make this decoupling a much harder task.
Closing. This has to be rethought because of the 3.7 changes. In short, there isn't a way to decouple the plugin and component now.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-07 16:51:37 |
| Closed_By | ⇒ | mbabker |
| Category | Administration Components Language & Strings Front End Plugins JavaScript | ⇒ | Administration com_content Language & Strings Front End JavaScript Plugins Components |
interresting i was trying to do somewhat the same thing for a new hits plugin andrepereiradasilva#94 (not completed and not working just a PoC)
I discovered that we also need:
1. ability to add optiions to select list fields dinamycly (i made a PR for this #12392). because of the ordering select and other.
2. A way to inject columns (th and td) in the views tables so we can add columns to views with a plugin. Is this possible now?