?
avatar mbabker
mbabker
22 Oct 2016

Steps to reproduce the issue

Review https://github.com/joomla/joomla-cms/blob/3.6.3/libraries/joomla/form/fields/list.php#L106-L120

Expected result

This should be a flexible option, like every other

Actual result

This option is hardcoded and only allows explicitly configured associations

avatar mbabker mbabker - open - 22 Oct 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

you about using something like

requires="plg_system_languagefilter"
requires="plg_system_languagefilter[item_associations:1]"
requires="plg_content_vote"
requires="com_banners"

And them in that line check if the component/plugin, etc is installed, enabled and user has acess level view right to it? If yes shown the option, if not don't show it.

if ok i can work on that

We need to preserve B/C tough

avatar mbabker
mbabker - comment - 22 Oct 2016

Looks fine to me.

avatar mbabker
mbabker - comment - 22 Oct 2016

We need to preserve B/C tough

Since the value's converted to an array, first thing I can think of is do this:

foreach ($requires as $require) {
    switch ($require) {
        case 'multilanguage':
            // Do existing stuff
            break;
        case 'associations':
            // Do existing stuff
            break;
        default:
            // Do new stuff
            break;
    }
}
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

just waht i was doing right now ;)

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

please test #12518

avatar zero-24
zero-24 - comment - 22 Oct 2016

Closing as we have a PR

avatar zero-24 zero-24 - change - 22 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-22 20:05:23
Closed_By zero-24
avatar zero-24 zero-24 - close - 22 Oct 2016
avatar zero-24 zero-24 - close - 22 Oct 2016
avatar zero-24 zero-24 - change - 24 Oct 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment