? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
16 Oct 2016

Summary of Changes

Convert installation template to html5, also move inline scripts to js

Testing Instructions

  1. Code review
  2. Apply patch in 3.7.x branch
  3. Delete configuration.php
  4. Install joomla as usual and confirm install works

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 16 Oct 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Category Installation
avatar ghazal
ghazal - comment - 17 Oct 2016

PHP 7.0.11
joomla 3.7dev (last version)

  • already installed

configuration.php deleted

installation folder added

file index.php modified

  • new install

file index.php modified

In both cases, I can't go past the first window (Configuration)
No JS error.

avatar ciar4n
ciar4n - comment - 17 Oct 2016

Similar story here, unable to proceed from step 1. Getting the following error in console when clicking 'Next'.

"NetworkError: 403 Forbidden - http://localhost/joomla-cms/installation/%3C?php%20echo%20JUri::current();%20?%3E"

Edit: Installing fine without the patch applied.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Oct 2016

my bad, sorry will correct

avatar ciar4n
ciar4n - comment - 17 Oct 2016

Installing fine however the 'Site Offline' toggle is appearing as follows...

install-switch

Without the patch
install-switch2

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Oct 2016

ok, please do not test will review all later again, since it seems there are some issues and i don't have much time right now.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Oct 2016

should work now.

removed all inline js and moved it to installation.js

@Fedik @dgt41 @ciar4n @ghazal please check and test

avatar andrepereiradasilva andrepereiradasilva - change - 17 Oct 2016
Title
[3.7.x] Convert installation template to html5 (also use the api for inline scripts)
[3.7.x] Convert installation template to html5 (also move inline scripts to js)
avatar andrepereiradasilva andrepereiradasilva - edited - 17 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2016
Category Installation Installation JavaScript
avatar andrepereiradasilva andrepereiradasilva - change - 17 Oct 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 17 Oct 2016
avatar ghazal
ghazal - comment - 18 Oct 2016

Can't post from Issues (Error : Missing commit SHA).
Already Installed and fresh installed versions of joomla 3.7 both work alright.

avatar brianteeman brianteeman - alter_testresult - 18 Oct 2016 - ghazal: Tested successfully
avatar brianteeman
brianteeman - comment - 18 Oct 2016

@ghazal - I have done it for you - but if you refresh your browser cache then you should see the sha now


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12444.

avatar ghazal ghazal - test_item - 18 Oct 2016 - Tested successfully
avatar ghazal
ghazal - comment - 18 Oct 2016

I have tested this item successfully on 748d4c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12444.

avatar ciar4n ciar4n - test_item - 18 Oct 2016 - Tested successfully
avatar ciar4n
ciar4n - comment - 18 Oct 2016

I have tested this item successfully on 748d4c1

All good! :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12444.

avatar brianteeman brianteeman - change - 18 Oct 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 18 Oct 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12444.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 25 Oct 2016
avatar rdeutz rdeutz - merge - 25 Oct 2016
avatar brianteeman brianteeman - close - 25 Oct 2016
avatar rdeutz rdeutz - change - 25 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-25 17:39:18
Closed_By rdeutz
avatar brianteeman brianteeman - change - 28 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment