[#12443] - [3.7.x] Input field invalid highlight
- Fixed in Code Base
- 9 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 12443
- Diff
- ciar4n:session-field
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12438 .
Summary of Changes
Adds highlight (border & text) to input fields if invalid.
Testing Instructions
Navigate to Global Configuration -> System. Check 'Session Lifetime' field with non integer number (0.5).
Before Patch
After Patch
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Templates (admin) |
Ah I was just thinking that. I'll change this to cover all fields.
| Title |
|
||||||
| Title |
|
||||||
Just FYI, input:invalid only works for IE10 and above. IE10 is still only partially supported.
in staging (3.6.3) template.css
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L1343
zero-24
- | Milestone |
Added: |
||
@andrepereiradasilva This CSS still exists in 3.7 however was been overridden. This is now the applied CSS with the latest commit so highlighting is now the same as 3.6. Thank you.
@C-Lodder True. I guess using javascript is the only B/C solution. I'll leave this PR to revert invalid highlighting to that of 3.6.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12443.
Mixing browser's native validation with joomla's own javascript validation will require something more than the css code. Don;t get me wrong I like the idea, but it needs more than this. Although this works fine (the problem is that the rest of the fields will not behave the same...)
@dgt41 This PR no longer adds any CSS. Instead it ensures that the original bootstrap 'invalid' CSS is been used as was the case in 3.6.. https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L1343
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12443.
Thank you. Forgotten about this.
| Easy | No | ⇒ | Yes |
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12443.
I have tested this item
tested successfully - but can it stay highlighted instead of fading out after leaving the focus?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12443.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12443.
Conflict fixes again please - sorry!
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 22:27:44 |
| Closed_By | ⇒ | rdeutz |
cpfeifer
-
hum ... imho this should be applied to all invalid fields (input, select, url, etc) not only session. i think in staging works like that