[#12395] - [3.7] Simplify instantiation of Registry
- Fixed in Code Base
- 12 Oct 2016
- Medium
- Build: 3.7.x
- # 12395
- Diff
- mbabker:registry-instantiation
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Following #12270 this simplifies the instantiation of Registry objects across the rest of the application. This also replaces a couple lingering uses of JRegistry.
Testing Instructions
Functions using the Registry object continue working as expected.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Repository Front End Components Tags Installation Libraries |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-12 10:28:43 |
| Closed_By | ⇒ | wilsonge |
What about removing the usage of $registry when not needed?
Working through that as able, some things are easier than others.
Thanks for not ignoring.
Too late for this PR, but thought about replacing
$data->params->merge($registry);
with
$data->params->merge(new Registry($data->params));
making $registry obsolete.
I was thinking about that last night but honestly couldn't remember if PHP 5.3 supported that syntax (this is the only place I write code anymore that has to retain 5.3 compatibility). All in all I'm trying to clean things up bit by bit which also makes cleaning stuff up in the 4.0 branch easier (like the places that are casting the Registry to a string could be replaced with (new Registry($data))->toString(); with 5.4+ syntax to avoid the needless variable AND keeping that stuff in memory).
What about removing the usage of $registry when not needed?