User tests: Successful: Unsuccessful:
This is the redo of PR #11255 against 3.7.x branch. Please see the other PR for details.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Category | ⇒ | Administration Components Media Manager Language & Strings Templates (admin) Layout Libraries Front End Plugins |
Thanks @brianteeman. Fixed in template manager, please check.
I have tested this item
I have tested this item
Looks great merging
Labels |
Added:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-16 13:58:44 |
Closed_By | ⇒ | zero-24 |
Hello,
Sorry first to see this late, but i just discovered that this apply then to all file type field, in third party too, but it display there the max server limit. (maybe an issue...)
Another suggestion would have been to disable this by default, and to create a xml attribute to turn on this info (or set it to "global media setting" OR custom limit value, if one want a smaller value than the global setting).
@izharaazmi What's your opinion on this ?
Best regards,
Cyril
I understand your concern. Please create a separate issue for this
mentioning this thread. Otherwise your comment would not be noticed on a
closed PR.
@izharaazmi it was just to have your opinion as you did this PR ;-)
I will better check this later (when a bit of time) and open a PR with needed options (as for now, in a 3PD extension using file type input, the message is displayed, but with server max limit, and not media set limit which is an issue, so i will have to look futher on this first).
Regards,
Cyril
Sure. my view was just to let the user know the max limit they can upload
as limited by whatever factor its limited by. Basically most of the places
the only limiting factor is the server limit, hence the display text. I
just focused on the being informative part when doing this PR.
We can surely improve that to show custom limit such as <field type="file" limit="20MB" showlimit="true"/>
to show 20MB or server limit whichever is
lesser.
Yes limit and showlimit are useful, but it should be disable by default.
Reason : file size could be checked php side, which could be a different value than server limit value.
If someone use this in its code :
<field
name="file"
type="file"
label="File Upload"
description="File Upload. Maximum upload limit : 1MB"
/>
<field
name="MAX_FILE_SIZE"
type="hidden"
default="1048"
/>
Reference docs : https://docs.joomla.org/File_form_field_type (Note 2)
Then, doing some control with php or ajax, it will display the server value, and it is not what the developer expects ;-)
If you agree (and don't have time to review this), i could check this in a few days to do the PR (options + disable by default for "minor" B/C reason).
Cyril
Intentando resolver un problema de uan web obsoleta y me ha servidor de ayuda, gracias
I have tested this item🔴 unsuccessfully on ea5b850
Tested with 3.7 and in the template manager it is not showing the correct values.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12396.