[#12394] - Native language (adjustments after 12036 merge)
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: staging
- # 12394
- Diff
- andrepereiradasilva:nativelanguage
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
One side effect of #12036 merge was that en-GB native language title English (United Kingdom) was replace is several language select fields (installation, admin login and user profile admin language) by English (en-GB)
This PR restaures the previous text by checking if the new nativeName metadata exists for the language, if so, will use it, if not, will fallback to name metadata.
Testing Instructions
Use 3.7.x branch
Go to
/installation/index.php?view=siteand confirm the title of en-GB language isEnglish (en-GB)
Apply patch
Repeat step and confirm the title of en-GB language title is
English (United Kingdom)
- Also confirm the same result in the admin login and user profile admin language select fields, ie, whenever joomla is using the xml files metadada to generate this select fields.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
I think the change here is expected.
1) JLanguageHelperTest::testCreateLanguageList
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
0 => Array (
- 'text' => 'English (en-GB)'
+ 'text' => 'English (United Kingdom)'
'value' => 'en-GB'
'selected' => 'selected="selected"'
)
)
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/joomla/language/JLanguageHelperTest.php:38
| Milestone |
Added: |
||
I have tested this item
OK here.
Needs one more tester.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12394.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
| Category | Libraries | ⇒ | Libraries Unit Tests |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12394.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 09:04:18 |
| Closed_By | ⇒ | zero-24 |
Merged thanks
| Labels |
Removed:
?
|
||
Looks like test is broken