Feeling Lucky
?
[#12282] - Cleaned up writeDynaList() and it's only usage
- Closed
- 4 Jan 2018
- Medium
- Build: 4.0-dev
- # 12282
- Diff
- milux:4.0-dev
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Function writeDynaList() in core.js was cleaned up. Conforming to its only usage one redundant parameter was removed. The function now always requires the last argument (element) and cannot anymore write to the document directly, because usage of document.write() and document.writeln() is a questionable approach, better replaced by DOM manipulation.
Testing Instructions
none
Documentation Changes Required
I'm not aware of any documentation about this function, so most likely none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
zero-24
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
brianteeman
- comment
- 4 Jan 2018
I am closing this as it appears that writeDynaList has been removed from the core.js file and the bug in moduleorder.js resolved. Probably here 3d976e4#diff-dff3a13ca1c06afc73dd123e9f435fd1
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:10:42 |
| Closed_By | ⇒ | brianteeman |
@dgt41