[#12283] - [3.7.x] Fix Regression #12277: language selector blocked on edit when there are no associations (multilanguage)
- Fixed in Code Base
- 3 Oct 2016
- Medium
- Build: 3.7.x
- # 12283
- Diff
- andrepereiradasilva:patch-17
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12277.
Summary of Changes
Fixes the regression on 3.7.x where the language selector blocked on edit when there are no associations (multilanguage)
Testing Instructions
- Use latest 3.7.x branch with multilingual
- Check the issue in #12277
- Apply patch
- Check that now you can edit the language if there are no associations.
- Test edit on contact, newsfeed, menu item, article and category (the ones that support associations) by adding and removing associations and checking the language field on the edit form.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Then change the language to ALL languages or to another Content language.
Do NOT save
Display the Associations tab.
The possible languages available for associations are the same as it was before changing the item language. They also appear when item language is set to ALL.
I guess we have to force saving the item again in a way or another.
That i know of what you descrivbe already existed before (see latest staging). Is not part of the regression this PR aims to correct. If so, please make a new issue for that.
indeed. do you think we can do something for that issue? maybe only a message and prevent saving?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12283.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12283.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12283.
| Status | Pending | ⇒ | Ready to Commit |
RTC @rdeutz
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12283.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-03 19:22:36 |
| Closed_By | ⇒ | rdeutz |
Removed RTC label
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
@andrepereiradasilva
I am afraid this is not enough.
To test, create an item tagged to a content language.
Save.
Then change the language to ALL languages or to another Content language.
Do NOT save
Display the Associations tab.
The possible languages available for associations are the same as it was before changing the item language. They also appear when item language is set to ALL.
I guess we have to force saving the item again in a way or another.
It is true that trying to select/create an associated item in the same language as the item edited will not work and that we get an error in the case when the original item language has been changed to ALL, but not really user friendly.