? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Sep 2016

Summary of Changes

Simple PR to Correct HTML error in the admin sidebar toggle button. (div element doesn't support type=button)

image

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 21 Sep 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Category Layout
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 21 Sep 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 21 Sep 2016
avatar zero-24 zero-24 - test_item - 21 Sep 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 21 Sep 2016

I have tested this item successfully on

works. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12131.

avatar ggppdk
ggppdk - comment - 21 Sep 2016

Nice, what about

<a ... type="button" ...>...</a>

can we also remove type="button" from them ?

avatar dgt41 dgt41 - test_item - 21 Sep 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 21 Sep 2016

I have tested this item successfully on 1764f6c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12131.

avatar dgt41 dgt41 - change - 21 Sep 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 21 Sep 2016

RTC

avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 23 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-23 18:31:16
Closed_By rdeutz
avatar rdeutz rdeutz - close - 23 Sep 2016
avatar rdeutz rdeutz - merge - 23 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment