? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
21 Sep 2016

Pull Request for 3.6.3

Summary of Changes

Deprecate FOF for Joomla 4.0

Testing Instructions

Code review

Documentation Changes Required

None here.

avatar zero-24 zero-24 - open - 21 Sep 2016
avatar zero-24 zero-24 - change - 21 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Category Libraries External Library
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 21 Sep 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Sep 2016

I have tested this item successfully on 4c0da17

code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12130.

avatar mbabker
mbabker - comment - 21 Sep 2016

I'd change the message to "include FOF if required" or something similar to
the social package notices personally (FOF3 can be installed via Composer).

On Wednesday, September 21, 2016, zero-24 notifications@github.com wrote:

Pull Request for 3.6.3
Summary of Changes

Deprecate FOF for Joomla 4.0
Testing Instructions

Code review
Documentation Changes Required

None here.

You can view, comment on, or merge this pull request online at:

#12130
Commit Summary

  • deprecate fof
  • deprecate fof

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12130, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSJH8QuaSeGtImjH4tCw6kw52ClJks5qsXcZgaJpZM4KDIFq
.

avatar zero-24
zero-24 - comment - 21 Sep 2016

done. Thanks @mbabker && @andrepereiradasilva

avatar andrepereiradasilva andrepereiradasilva - test_item - 21 Sep 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Sep 2016

I have tested this item successfully on 3e564b1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12130.

avatar jeckodevelopment jeckodevelopment - test_item - 21 Sep 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 21 Sep 2016

I have tested this item successfully on 3e564b1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12130.

avatar jeckodevelopment jeckodevelopment - change - 21 Sep 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 21 Sep 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12130.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 22 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-22 00:10:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Sep 2016
avatar wilsonge wilsonge - merge - 22 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 22 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 22 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2016
Category Libraries External Library Installation SQL Postgresql MS SQL Libraries External Library
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2016
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment