? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Sep 2016

Summary of Changes

Simple PR to correct html output table errors (th without thead, missing tr, etc).

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 21 Sep 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Category Plugins Front End
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Sep 2016

Where is this used?

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Sep 2016

used in this table

image

avatar brianteeman
brianteeman - comment - 22 Sep 2016

Thats what I thought but I dont see any tables there only divs

On 22 September 2016 at 13:19, andrepereiradasilva <notifications@github.com

wrote:

used in this table

[image: image]
https://cloud.githubusercontent.com/assets/9630530/18744534/5bb4b4b2-80b6-11e6-9c7b-f1c8a03cd647.png


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VMrQxUvIP6FmCvYWQK1bdbm-z10ks5qslYcgaJpZM4KDHyG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Sep 2016

for instance the debug callstack table in database queries

avatar brianteeman
brianteeman - comment - 22 Sep 2016

stupid question - how do I enable the callstack?

On 22 September 2016 at 13:24, andrepereiradasilva <notifications@github.com

wrote:

for instance the debug callstack table


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UG3r0qJJFDtq-mUwMsNH4P3-YAfks5qsldTgaJpZM4KDHyG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Sep 2016

just enable (if not yet) database queries

image

avatar brianteeman
brianteeman - comment - 22 Sep 2016

Doh

avatar brianteeman
brianteeman - comment - 23 Sep 2016

The debug call stack does have a th inside a thead I must be missing something

smxu

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Oct 2016

sorry @brianteeman you're right

the errors are in the explain and profile tables

image

avatar zero-24 zero-24 - test_item - 2 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 2 Oct 2016

I have tested this item successfully on f631fb5

?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12129.

avatar truptikagathara truptikagathara - test_item - 3 Oct 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 3 Oct 2016

I have tested this item successfully on f631fb5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12129.

avatar zero-24 zero-24 - change - 3 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 3 Oct 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12129.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Oct 2016

Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Oct 2016

ok. so the base branch should be changed too to check for conflicts.
Will change it

avatar rdeutz rdeutz - close - 18 Oct 2016
avatar rdeutz rdeutz - merge - 18 Oct 2016
avatar brianteeman brianteeman - close - 18 Oct 2016
avatar rdeutz rdeutz - change - 18 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-18 17:33:10
Closed_By rdeutz
avatar brianteeman brianteeman - change - 18 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment