[#12088] - Config Media - blue bar with Fieldset Description
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 12088
- Diff
- pe7er:info-label-options-media
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Most Component Configuration Options have under the option tab a blue bar with a description
Summary of Changes
This PR changes the tab option name from [Component] to [Upload Settings] and adds a blue bar with description.
Testing Instructions
Before the PR:
backend: System > Global Configuration > (in Left menu) Media > [Component]
After the PR:
backend: System > Global Configuration > (in Left menu) Media > [Upload Settings]
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Media Manager Administration Components Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12088.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12088.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12088.
This is not correct - see comments inline
@brianteeman What would be correct? "Configure the media upload settings."
The only correct string to cover all the current options and the potential future options would be to say these are the options for the media manager component. But the blue bar is not needed -this would just add meaningless text in order to justify adding th blue bar - my 2c
Ok. I understand your point but if every Options tab starts with a blue bar with some information, the UI for Options will be consistently the same on all Option Tabs. That way an admin has an extra visual pointer (besides the "Options" in the Page Title) that they are on the Options page.
I don't agree in adding help text if it has no meaning or value. That has
the effect of users just ignoring it. It should only exist if it is
required information
On 21 Sep 2016 4:06 p.m., "Peter Martin" notifications@github.com wrote:
Ok. I understand your point but if every Options tab starts with a blue
bar with some information, the UI for Options will be consistently
the same on all Option Tabs. That way an admin has an extra visual
pointer (besides the "Options" in the Page Title) that they are on the
Options page.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12088 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YXAQUtPwURd7J8iJ38n0d3DFjtdks5qsSvKgaJpZM4KBIJT
.
franz-wohlkoenig
- | Status | Pending | ⇒ | Needs Review |
It has been tested succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12088.
I concur with Brian. The left sidebar menu is enough visual cue that I’m on the Options page.
Closed for the reasons stated above and elsewhere
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:23:05 |
| Closed_By | ⇒ | brianteeman |
I do not understand why Travis is unhappy.
If someone can shed a light on that then I might be able to improve this PR.
Thanks!