[#12087] - Config Users - blue bar with Fieldset Description
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 12087
- Diff
- pe7er:info-label-options-users
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Most Component Configuration Options have under the option tab a blue bar with a description
Summary of Changes
This PR adds a blue bar with description to User Options, Password Options and User Notes History to make it consistent with other options & components.
Testing Instructions
Before the PR:
backend: System > Global Configuration > (in Left menu) Users > [User Options]
backend: System > Global Configuration > (in Left menu) Users > [Password Options]
backend: System > Global Configuration > (in Left menu) Users > [User Notes History]
After the PR:
backend: System > Global Configuration > (in Left menu) Users > [User Options]
backend: System > Global Configuration > (in Left menu) Users > [Password Options]
backend: System > Global Configuration > (in Left menu) Users > [User Notes History]
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12087.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12087.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12087.
@brianteeman we need you also here!
@jeckodevelopment commented inline - this PR is not correct
Thanks
The blue bar is really not needed - you just added some meaningless text in order to justify adding th blue bar - my 2c
I understand your point but if every Options tab starts with a blue bar with some information, the UI for Options will be consistently the same on all Option Tabs. That way an admin has an extra visual pointer (besides the "Options" in the Page Title) that they are on the Options page.
I don't agree in adding help text if it has no meaning or value. That has
the effect of users just ignoring it. It should only exist if it is
required information
On 21 Sep 2016 4:05 p.m., "Peter Martin" notifications@github.com wrote:
I understand your point but if every Options tab starts with a blue bar
with some information, the UI for Options will be consistently the
same on all Option Tabs. That way an admin has an extra visual pointer
(besides the "Options" in the Page Title) that they are on the Options page.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12087 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZDK-mrHCtQULvFmf1zccpBtqSK3ks5qsSucgaJpZM4KBHsd
.
I agree with @BrianTeeman. If the information bar doesn't add any value then it should not be added. It should not be added just to be consistently.
It might be better to change the title of the tabs which do need the information bar.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12087.
franz-wohlkoenig
- | Status | Pending | ⇒ | Needs Review |
| Category | Administration Components Language & Strings | ⇒ | Administration com_users Language & Strings Components |
Closing for the reasons stated above
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:20:54 |
| Closed_By | ⇒ | brianteeman |
I have tested this item✅ successfully on 0deed5e
?
works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12087.