Joomla! Issue Tracker | Joomla! CMS #12086 - User Groups - removed label: enabled/disabled users

Closed
10 Sep 2017
Medium
Build: staging
# 12086
Diff
pe7er:user-groups-enabled-disabled-users

Failure

Success continuous-integration/drone the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
Pending JTracker/HumanTestResults Human Test Results: 4 Successful 2 Failed. Details

User tests: Successful: Unsuccessful:

pe7er
20 Sep 2016

On the User Groups page is the layout of the columns Enabled users and Disabled users and their columns are IMHO not nice.

Summary of Changes

This PR removes the text labels Enabled users and Disabled users so that the layout looks better and more in consistent with the similar columns of the item counters on the Category page (Content > Categories)

Testing Instructions

Before the PR:

backend: Users > User Groups

After the PR:

backend: Users > User Groups

612400b 20 Sep 2016

User Groups - removed label: enabled/disabled users

pe7er - open - 20 Sep 2016

pe7er - change - 20 Sep 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Sep 2016

Category

⇒

Administration Components

joomla-cms-bot - change - 20 Sep 2016

Labels

Added: ?

zero-24 - comment - 20 Sep 2016

looks much better but maybe we can move that colum a bit left atleast on desktop? As there are now much unused space:

RonakParmar - test_item - 20 Sep 2016 - Tested successfully

RonakParmar - comment - 20 Sep 2016

I have tested this item ✅ successfully on 612400b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.}

brianteeman - comment - 20 Sep 2016

Not in favour of this change as it is right now a we still have the clumns enabled/disabled in the users view

tomartailored - test_item - 23 Sep 2016 - Tested successfully

tomartailored - comment - 23 Sep 2016

I have tested this item ✅ successfully on 612400b

i have tested this item successfully

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.}

JamalTailored - test_item - 24 Sep 2016 - Tested successfully

JamalTailored - comment - 24 Sep 2016

I have tested this item ✅ successfully on 612400b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12086.}

hans2103 - test_item - 4 Nov 2016 - Tested unsuccessfully

hans2103 - comment - 4 Nov 2016

I have tested this item ? unsuccessfully on 612400b

With this patch applied the text "Enabled users" and "Disabled users" will disappear... but due to the classes "hidden-phone hidden-tablet" on the th element the table header will disappear too. Result in meaningless columns.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12086.}

franz-wohlkoenig - comment - 11 Jan 2017

I have tested this item ? unsuccessfully on 612400b

On smaller Devices the meaning of columns is not clear because some or all Icons are at
wrong position:

or gone