[#12089] - Config Menus - blue bar with Fieldset Description
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 12089
- Diff
- pe7er:info-label-options-menus
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Most Component Configuration Options have under the option tab a blue bar with a description
Summary of Changes
This PR adds a blue bar with description to Menus: Options.
Testing Instructions
Before the PR:
backend: System > Global Configuration > (in Left menu) Menus > [Page display]
After the PR:
backend: System > Global Configuration > (in Left menu) Menus > [Page display]
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12089.
@brianteeman please review so we can go RTC
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12089.
The blue bar is not needed - you just added some meaningless text in order to justify adding th blue bar - my 2c
No, I added the blue bar + info text to make it consistent with most other Component Configuration Options. Most of the Tabs of core Component Options have a blue bar with some info about the settings on that tab.
Having a blue bar with info text makes the Option Tabs consistent which makes it easier to navigate & easily see that you are in the Options tab.
franz-wohlkoenig
- | Status | Pending | ⇒ | Needs Review |
| Category | Administration Components Language & Strings | ⇒ | Administration com_menus Language & Strings Components |
It has been tested succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12089.
Agree with Brian's analysis. At first glance it seems like we're adding text for the sake of adding text or a display consistency with something else.
so, can we close it?
Closed for the reasons stated above and elsewhere
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:22:45 |
| Closed_By | ⇒ | brianteeman |
I have tested this item✅ successfully on
looks good.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12089.