? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
19 Sep 2016

Summary of Changes

After this PR we show if the user has enabled or disabled the TFA

Testing Instructions

  • Apply this patch
  • Check the Users view in the backend
  • see the new colum TFA Status is disabled
  • enabled tfa for an user
  • see that it shows that you have TFA enabled. ### Documentation Changes Required

Maybe the help screens?

avatar zero-24 zero-24 - open - 19 Sep 2016
avatar zero-24
zero-24 - comment - 19 Sep 2016

The new feature in the backend:
image

avatar zero-24 zero-24 - change - 19 Sep 2016
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Category Administration Components Language & Strings
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar jeckodevelopment
jeckodevelopment - comment - 19 Sep 2016

I'd change the Column name in "2FA" and display a or ? for the status, for consistency with the "Enabled" and "Activated" columns.

see zero-24#18 for the column name

avatar zero-24 zero-24 - change - 20 Sep 2016
Status New Pending
avatar brianteeman
brianteeman - comment - 21 Sep 2016

This is not correct for me. I would not display this column at all if there are no tfa plugins enabled. I agree it is useful to see which user has enabled tfa when tfa is active on the site. But when its not even enabled then it is just useless information.

I also agree with @jeckodevelopment that the display should be consistent with similar fields


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12082.

avatar brianteeman brianteeman - test_item - 21 Sep 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 21 Sep 2016

I have tested this item ? unsuccessfully on 22c6ed4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12082.

avatar zero-24
zero-24 - comment - 21 Sep 2016

Thanks for the feedback i can have a look into that later this week.

avatar zero-24
zero-24 - comment - 21 Sep 2016

I have just pushed some changes but i have not found a easy way to display it as and ? do i miss simething or do i need to implement it myself?

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Sep 2016

<span class="icon-publish"></span>
<span class="icon-unpublish"></span>

Used in articles modal https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/views/articles/tmpl/modal.php#L111

avatar jeckodevelopment
jeckodevelopment - comment - 21 Sep 2016

@zero-24 are you going to follow this suggestion?

would not display this column at all if there are no tfa plugins enabled.

avatar zero-24
zero-24 - comment - 22 Sep 2016

@zero-24 are you going to follow this suggestion?

@jeckodevelopment yes with c0ecb41

Thanks @andrepereiradasilva i'm going to implment that later today ?

<span class="icon-publish"></span>
<span class="icon-unpublish"></span>

Used in articles modal https://github.com/joomla/joomla->cms/blob/staging/administrator/components/com_content/views/articles/tmpl/modal.php#L111

avatar zero-24
zero-24 - comment - 22 Sep 2016

I have implemented the icon with the last commit. Thanks @andrepereiradasilva

avatar brianteeman brianteeman - test_item - 12 Oct 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 12 Oct 2016

I have tested this item ? unsuccessfully on 6eaccda

See https://github.com/joomla/joomla-cms/pull/12082/files#r83108442


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12082.

avatar brianteeman
brianteeman - comment - 12 Oct 2016

If we are going to introduce the ABBR then we should do that everywhere

On 12 October 2016 at 23:37, andrepereiradasilva notifications@github.com
wrote:

@andrepereiradasilva commented on this pull request.

In administrator/components/com_users/views/users/tmpl/default.php
#12082:

@@ -53,6 +56,11 @@

<?php echo JHtml::_('searchtools.sort', 'COM_USERS_HEADING_ACTIVATED', 'a.activation', $listDirn, $listOrder); ?>

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar jeckodevelopment
jeckodevelopment - comment - 13 Oct 2016

I agree with Brian. For consistency, i would see a tooltip even here.

avatar zero-24
zero-24 - comment - 15 Oct 2016

Sorry i did not notice that i have something to do here ;) Done now

avatar brianteeman
brianteeman - comment - 15 Oct 2016

Thanks for removing the Abbr but are you not going to add the tooltip?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12082.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Oct 2016

i still think the abbreviations should be expanded with abbr across joomla. reggardless of having tooltipo or not.

avatar brianteeman brianteeman - change - 29 Oct 2016
Labels Added: ?
Removed: ?
avatar zero-24
zero-24 - comment - 13 Nov 2016

Any news here or can this be closed?

avatar brianteeman
brianteeman - comment - 13 Nov 2016

Why close it?

avatar zero-24
zero-24 - comment - 14 Nov 2016

I have submitted it to j-over.de if it is live i'm going to add the link here. Thanks!

avatar zero-24 zero-24 - change - 14 Nov 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-14 13:04:13
Closed_By zero-24
Labels Removed: ? ?
avatar zero-24 zero-24 - close - 14 Nov 2016
avatar zero-24 zero-24 - close - 14 Nov 2016
avatar zero-24 zero-24 - head_ref_deleted - 14 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Nov 2016
Category Administration Components Language & Strings Administration com_users Language & Strings Components
avatar brianteeman
brianteeman - comment - 14 Nov 2016

:(

On 14 November 2016 at 13:04, zero-24 notifications@github.com wrote:

Closed #12082 #12082.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8QXXjvPNyxFCF3cs0XQbM_gLF1vsks5q-FxLgaJpZM4KA8cx
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 14 Nov 2016

You can still use it if you want ? it is not lost here is the GIST: https://gist.github.com/zero-24/bfc713cd8c3e16680cdf7cefd495e154 but it looks like there no need for this in the core.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

On what basis are you making that decision that there is no need for it?
Looks very useful to me which is why I tested it

On 14 November 2016 at 13:26, zero-24 notifications@github.com wrote:

You can still use it if you want ? it is not lost here is the GIST:
https://gist.github.com/zero-24/bfc713cd8c3e16680cdf7cefd495e154 but it
looks like there no need for this in the core.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SiZyMKTeotZ7T9PoPMThwmKKxhTks5q-GGEgaJpZM4KA8cx
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 14 Nov 2016

Looks very useful to me which is why I tested it

Here it is: https://www.j-over.de/de/template-override/andere/zwei-faktor-status-pro-user-anzeigen.html

avatar brianteeman
brianteeman - comment - 14 Nov 2016

I am not going to override anything in my admin

On 14 November 2016 at 13:54, zero-24 notifications@github.com wrote:

Looks very useful to me which is why I tested it

Here it is: https://www.j-over.de/de/template-override/andere/zwei-
faktor-status-pro-user-anzeigen.html


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RizQCGo9U9e1g4OgE-w2eALitDiks5q-GgigaJpZM4KA8cx
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment