User tests: Successful: Unsuccessful:
After this PR we show if the user has enabled or disabled the TFA
TFA Status
is disabledMaybe the help screens?
Labels |
Added:
?
?
?
|
Category | ⇒ | Administration Components Language & Strings |
Labels |
Added:
?
|
I'd change the Column name in "2FA" and display a
see zero-24#18 for the column name
Status | New | ⇒ | Pending |
This is not correct for me. I would not display this column at all if there are no tfa plugins enabled. I agree it is useful to see which user has enabled tfa when tfa is active on the site. But when its not even enabled then it is just useless information.
I also agree with @jeckodevelopment that the display should be consistent with similar fields
I have tested this item
Thanks for the feedback i can have a look into that later this week.
I have just pushed some changes but i have not found a easy way to display it as
<span class="icon-publish"></span>
<span class="icon-unpublish"></span>
Used in articles modal https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/views/articles/tmpl/modal.php#L111
@zero-24 are you going to follow this suggestion?
@jeckodevelopment yes with c0ecb41
Thanks @andrepereiradasilva i'm going to implment that later today
<span class="icon-publish"></span>
<span class="icon-unpublish"></span>
Used in articles modal https://github.com/joomla/joomla->cms/blob/staging/administrator/components/com_content/views/articles/tmpl/modal.php#L111
I have implemented the icon with the last commit. Thanks @andrepereiradasilva
I have tested this item
See https://github.com/joomla/joomla-cms/pull/12082/files#r83108442
If we are going to introduce the ABBR then we should do that everywhere
On 12 October 2016 at 23:37, andrepereiradasilva notifications@github.com
wrote:
@andrepereiradasilva commented on this pull request.
In administrator/components/com_users/views/users/tmpl/default.php
#12082:@@ -53,6 +56,11 @@
<?php echo JHtml::_('searchtools.sort', 'COM_USERS_HEADING_ACTIVATED', 'a.activation', $listDirn, $listOrder); ?>
- <?php if ($tfa) : ?>
- https://github.com/joomla/joomla-cms/pull/12082, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YpgjDyXmcd65tgMmLAomtR59kMeks5qzWEXgaJpZM4KA8cx
.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I agree with Brian. For consistency, i would see a tooltip even here.
Sorry i did not notice that i have something to do here ;) Done now
Thanks for removing the Abbr but are you not going to add the tooltip?
i still think the abbreviations should be expanded with abbr across joomla. reggardless of having tooltipo or not.
Labels |
Added:
?
Removed: ? |
Any news here or can this be closed?
Why close it?
I have submitted it to j-over.de if it is live i'm going to add the link here. Thanks!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-14 13:04:13 |
Closed_By | ⇒ | zero-24 | |
Labels |
Removed:
?
?
|
Category | Administration Components Language & Strings | ⇒ | Administration com_users Language & Strings Components |
:(
On 14 November 2016 at 13:04, zero-24 notifications@github.com wrote:
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8QXXjvPNyxFCF3cs0XQbM_gLF1vsks5q-FxLgaJpZM4KA8cx
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
You can still use it if you want
On what basis are you making that decision that there is no need for it?
Looks very useful to me which is why I tested it
On 14 November 2016 at 13:26, zero-24 notifications@github.com wrote:
You can still use it if you want
? it is not lost here is the GIST:
https://gist.github.com/zero-24/bfc713cd8c3e16680cdf7cefd495e154 but it
looks like there no need for this in the core.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SiZyMKTeotZ7T9PoPMThwmKKxhTks5q-GGEgaJpZM4KA8cx
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Looks very useful to me which is why I tested it
Here it is: https://www.j-over.de/de/template-override/andere/zwei-faktor-status-pro-user-anzeigen.html
I am not going to override anything in my admin
On 14 November 2016 at 13:54, zero-24 notifications@github.com wrote:
Looks very useful to me which is why I tested it
Here it is: https://www.j-over.de/de/template-override/andere/zwei-
faktor-status-pro-user-anzeigen.html—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12082 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RizQCGo9U9e1g4OgE-w2eALitDiks5q-GgigaJpZM4KA8cx
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
The new feature in the backend:
