Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12081] - [JInstaller::parseXMLInstallFile] Parse also metadata section of manifest files

? ? Failure

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
19 Sep 2016

Summary of Changes

This PR allow JInstaller::parseXMLInstallFile to also parse the metadata section in xml files (ex: xml language files).

Testing Instructions

Code review.

  • add this to your isis/index.php and refresh the page you will see the array with that xml file.
print_r(JInstaller::parseXMLInstallFile(JPATH_SITE . '/language/en-GB/install.xml'));
  • Now add this to the end of the en-GB install.xml file:
    [...]
    </files>
    <metadata>
        <name>English (en-GB)</name>
        <tag>en-GB</tag>
        <rtl>0</rtl>
        <locale>en_GB.utf8, en_GB.UTF-8, en_GB, eng_GB, en, english, english-uk, uk, gbr, britain, england, great britain, uk, united kingdom, united-kingdom</locale>
        <firstDay>0</firstDay>
        <weekEnd>0,6</weekEnd>
    </metadata>
    <params />
</extension>
  • Refresh page. You will see the metadata section IS NOT there.
  • Apply patch.
  • Refresh page. You will see the metadata section IS there.
  • Install any extension, language to confirm all installs fine.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 19 Sep 2016
avatar andrepereiradasilva andrepereiradasilva - change - 19 Sep 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Category ⇒ Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 19 Sep 2016

just one smal one ;)

avatar zero-24
zero-24 - comment - 20 Sep 2016

i'm not sure. But the code gives me the same with and without the patch and anytime without the metadata? I'm confused but maybe i miss something?

avatar zero-24 zero-24 - test_item - 20 Sep 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 20 Sep 2016

I have tested this item ✅ successfully on 3b810e0

works. it was a wrong setup problem here ;) Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12081.

avatar andrepereiradasilva andrepereiradasilva - change - 2 Jan 2017
The description was changed
avatar mbabker
mbabker - comment - 21 May 2017

This PR needs a new owner or it will have to be closed as abandoned.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 May 2017
The description was changed
Status Pending ⇒ Information Required
avatar joomla-cms-bot joomla-cms-bot - edited - 22 May 2017
avatar zero-24
zero-24 - comment - 22 May 2017

The bot is was your friend this day @mbabker ;)

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

If this PR get no Response, it will be closed at 23th July 2017.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jul 2017
Status Information Required ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-07-23 08:24:34
Closed_By ⇒ franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Jul 2017

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12081

avatar joomla-cms-bot joomla-cms-bot - close - 23 Jul 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jul 2017

closed as stated above.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12081.

Add a Comment

Login with GitHub to post a comment