[#12066] - [JAccess] Calculate if user is super user using JAccess preloading (3.7.x)
- Closed
- 7 Nov 2016
- Medium
- Build: staging
- # 12066
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR aims to improve performance in super user calculation by taking advantage of asset access preloading.
The following tests were made with a super user logged in frontend homepage in sample multilingual site.
Before
After
Testing Instructions
- Code review.
- Apply patch on 3.7.x branch.
- Login and logout with a super user and without a superuser.
- Check if super user permissions are ALWAYS correctly identified in all circunstances.
Note: Please test this careful as this is the super user permissions ...
Documentation Changes Required
None.
mantainers please confirm the root asset is always called root.1 and id is always 1
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
Works now (i can see there are just 25 queries and less memory usage)
but how can i test this:
Check if super user permissions are ALWAYS correctly identified in all circunstances.
Any special or just navigate the backend?
for instance, you need to create some users assigned to several grups give some of them super user permissions, other not, log with them and check if the ones that should be superusers are super users, the others not.
ok it is on my list for tomorrow
I have tested this item
ok it was not exact tomorrow
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12066.
brianteeman
- | Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-07 12:20:03 |
| Closed_By | ⇒ | andrepereiradasilva |
Also after the patch I get 28 Queries logged and on afterRender is not changed here? I'm confused.