Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12067] - [4.0] PHPCS Fixes, Abstract Daemon Class

? ? Failure

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
18 Sep 2016

Summary of Changes

  • Fixes the PHPCS issues on the 4.0 branch, includes changing the file comment sniff to ignore the @package tag requirement for namespaced code
  • Removes the $config property declaration in the Autoconfigurable app trait; PHP 5.x groans about this being declared in the trait and the class hierarchy
  • Makes JApplicationDaemon abstract; its parent JApplicationCli is also abstract and the class doesn't provide anything useful to keep it concrete

Testing Instructions

Review the changes

Documentation Changes Required

Document JApplicationDaemon is now abstract. Odds are though it affects nobody 😉

avatar mbabker mbabker - open - 18 Sep 2016
avatar mbabker mbabker - change - 18 Sep 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Category ⇒ Repository Tags Front End Components Libraries Plugins Unit Tests
avatar zero-24
zero-24 - comment - 22 Sep 2016

@mbabker there is just one more left for CS do you want to do it here or in a different PR?

FILE: ...d/joomla/joomla-cms/libraries/src/Cms/Session/Storage/JoomlaStorage.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 56 | ERROR | Arguments with default values must be at the end of the argument
    |       | list
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
avatar mbabker
mbabker - comment - 22 Sep 2016

Already a separate PR. Seems Travis changed something in how it's testing, that file doesn't actually exist in the branch as it's several commits behind the base 4.0 branch yet it's in the report.

avatar zero-24 zero-24 - change - 22 Sep 2016
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 22 Sep 2016

RTC. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12067.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2016
Labels Added: ?
avatar mbabker
mbabker - comment - 22 Sep 2016

@wilsonge This and #12141 need to be merged to fix the PHPCS issues, the "false" passing PHPUnit builds on 5.x (the trait composition message), and the heavy memory consumption in PHPUnit. Either #12134 needs to be merged or the JCrypt constructor fixed to not reference the removed simple crypt class.

avatar wilsonge wilsonge - change - 23 Sep 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-09-23 08:52:10
Closed_By ⇒ wilsonge
avatar zero-24 zero-24 - change - 23 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment