[#12065] - [4.0] B/C Break - Recompose JApplicationCli to extend the Framework
- Fixed in Code Base
- 18 Sep 2016
- Medium
- Build: 4.0-dev
- # 12065
- Diff
- mbabker:rebase-cli-app
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
JApplicationCli is recomposed to inherit from the Framework's Joomla\Application\AbstractCliApplication class now. This allows the CMS app class to use all features from the Framework.
To do so without losing features, several behaviors from the CMS app class chain are moved into traits and those are now used as appropriate.
This also follows through with the noted change to JApplicationCli to make it abstract.
Testing Instructions
For CLI applications, they should continue to function as is with no changes. The changes I did make to the doExecute method signatures just causes the visibility to match the parent definition.
Web applications should work too. Because of the trait implementations their code is reshuffled a bit but nothing changes from a practical standpoint.
Documentation Changes Required
The class inheritance for JApplicationCli has changed, this will break instanceof checks.
3.x:
JApplicationCliJApplicationBaseJoomla\Application\AbstractApplication
4.0:
JApplicationCliJoomla\Application\AbstractCliApplicationJoomla\Application\AbstractApplication
Also, as documented, JApplicationCli is now abstract.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration CLI Libraries Unit Tests |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-18 15:09:47 |
| Closed_By | ⇒ | wilsonge |
Correct. We can add a 4.x milestone
Thanks
Documentation added at https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4
@wilsonge i think there is no reason to not add the 4.0 milestone correct?