Feeling Lucky
?
?
[#12064] - [4.0] Fix Test Suite
- Fixed in Code Base
- 19 Sep 2016
- Medium
- Build: 4.0-dev
- # 12064
- Diff
- mbabker:4.0-test-fixes
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- In the application class, catch exceptions if an event dispatcher is not set
- Default behavior for
loadIdentity()is to load a nullJUserobject instead of trying to load the user out of the factory (and inherently the session) - Missing a use statement for setting the event dispatcher which breaks the typehint
- Check if a dispatcher exists in injector methods before trying to set it as the trait doesn't allow a null argument
- Tweak the OAuth1 client class to pull dependencies from the application
- Default to creating a mocked event dispatcher when using the mocker APIs to create an application
- Allow the app's
setSessionmethod to be mocked - Refactor the mocked event dispatcher for full compatibility with the new API
Testing Instructions
Validate unit tests pass, review code changes
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Libraries Unit Tests |
mbabker
- comment
- 19 Sep 2016
It's patched already in one of my other PRs.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-19 23:02:31 |
| Closed_By | ⇒ | wilsonge |
Is the php 7/HHVM error in travis something "known" in the 4.x development, or something that needs to be addressed?
Fatal error: Class JApplicationDaemon contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Joomla\Application\AbstractApplication::doExecute) in /libraries/joomla/application/daemon.php on line 915