[#11998] - [NF] Menu item visibility indicator
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 11998
- Diff
- Devportobello:menuitemVisibilityIndicator
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Context
The new feature of the menu component allowing to show/hide a menu item from params, when we watch all items we can't know if item is hidden or not.
Testing Instructions
- Create a menu with some items, hide some with the param: "Display in Menu"
- Take a look at the list of items, unable to know who is hidden or not
Patch
- Now you can know hidden or not ### Work in progress
i dunno if the icon is at the right place (before title)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
jeckodevelopment
- | Labels |
Added:
?
|
||
Instead of showing an icon (with a tooltip) maybe you can just show a small label that says "hidden" behind the title. Similar to how we show unpublished articles in frontend to the admins.
That would work too
@brianteeman @Bakual
Ye i agree with you
Label will add a new text translation, adding "JHIDDEN" in "en-GB.ini" is the right approach ?
I wouldn't make it a global string. It's only used in the menu manager. Just put it into the en-GB.com_menus.ini and name it something like COM_MENUS_LABEL_HIDDEN.
| Labels |
Added:
?
|
||
| Category | Administration Components | ⇒ | Administration Components Language & Strings |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11998.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11998.
I have tested this item
Tested successfully at PBF NL
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11998.
I have tested this item
After applying the patch the hidden notice shows behind the menu item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11998.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Setting to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11998.
| Labels | |||
| Labels |
Added:
?
Removed: ? |
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 11:04:44 |
| Closed_By | ⇒ | roland-d |
I see what you are trying to do but I dont think this is the correct approach.
As the majority of menu items will be visible I dont see the need to always show the eye-icon
So I would probably only show the icon for items that are invisible and I would display that after the title.
Also you need some sort of tooltip/popover to explain the meaning of the icon