[#11997] - [JLanguage] Do not run the load language file method twice in the default language
- Fixed in Code Base
- 10 Sep 2016
- Medium
- Build: staging
- # 11997
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When loading language files for the en-GB language JLanguage::load method is trying to load the en-GB files two times when it only needs to do that one time.
This PR intends to corrects that.
Testing Instructions
- Code review
- Use latest staging
- Enable debug global option and system debug plugin
- Add, before and after
JLanguage::load(https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/language.php#L724) method a profiler mark like this:
public function load($extension = 'joomla', $basePath = JPATH_BASE, $lang = null, $reload = false, $default = true)
{
!JDEBUG ?: JProfiler::getInstance('Application')->mark('');
// Code removed for brevity
!JDEBUG ?: JProfiler::getInstance('Application')->mark('<strong>Loaded</strong> ' . str_replace(JPATH_ROOT, '', $filename));
return $result;
}- Check in the debug plugin "Profile Information" that the
loadmethod is being called two times in en-GB for each language file.
- Apply patch
- Add the profiler marks again to the file
Check in the debug plugin "Profile Information" that the
loadmethod is being called one time for en-GB for each language file.
Check if all language are still loaded correctly across joomla
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11997.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11997.
Works fine here.
Note: I remarked some weird double loading in frontend (Tested in multilingual site, first with en-GB):
For Protostar:
same for mod_menu.ini which is loaded for each menu
On a multillingual site, as both lang files are loaded, it gets heavier when double load.
At first switch from en-GB to fr-FR, it seems Joomla "remembers" :
Loading another menu or reloading page:
we still get the protostar (same for isis in back-end) and menu double load, no more the main ini and main lib_joomla.ini
Would be nice to solve this.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Please tag this to 3.6.3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11997.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-10 13:04:07 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
There are a bunch of places that load the template language files which is why you've got multiple calls for those. If you're interested, load up the 3.7 branch and add my language debug plugin that I've been messing with locally and you'll see a lot more info about that.
thanks andre
is more readable now even for me ;)