[#11999] - [NF] Module menu assignment display visibility of item
- Closed
- 12 Jul 2017
- Medium
- Build: staging
- # 11999
- Diff
- Devportobello:ModuleMenuAssignementItemVisibility
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add ability to know the visibility of a menu item in the module menu assignment
Testing Instructions
- Create many menu items, hide some of them
- Create or edit a module, go to the "menu assignment" tab, select "Only on the pages selected"
- Unable to know if menu item in list are hidden or not
Patch
- Now able to know hidden or not
Work in progress
I dunno if we need to use an "icon" or text "Hidden"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11999.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11999.
@Devportobello can you look at the issues with this PR?
My bad, was working on j3.6.2...
The error occur with sample data test: string '{"show_base_description":"1","categories_description":"Because this links to the root category the "uncategorised" category is displayed. ","maxLevel":"-1","show_empty_categories":"1","show_description":"1","show_description_image":"1","show_cat_num_articles":"1","display_num":"","show_headings":"","orderby_pri":"","orderby_sec":"","order_date":"","show_pagination":"","show_noauth":"","show_feed_image":"","show_feed_description":"","show_item_description":"","feed_character_count":"0","show_feed_link":"","f'... (length=737)
Json error: JSON_ERROR_SYNTAX
What is the best way to handle that ? using try/catch or there is already an issue with the data saved in DB ?
| Labels |
Added:
?
|
||
| Category | Administration Components | ⇒ | Administration Components Language & Strings |
I have tested this item
No idea if the code you wrote to handle the json issue is correct. But assuming it is then I have tested this successfully
(You will need to add the hidden flag to the template assignment as well)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11999.
(You will need to add the hidden flag to the template assignment as well)
sorry i dont understand
You have added it to the menu listing in the menu manager and the module manager but we also get a menu listing in the template styles where you can assign a template style to a menu item
oh, still missing some other improvment : https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/views/module/tmpl/edit_assignment.php#L113-L121
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11999.
I have tested this item
works4me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11999.
unable to find conflict !
@Devportobello
Conflicting file:
administrator/components/com_modules/views/module/tmpl/edit_assignment.php
Failed to resolve that conflicts, dunno why im unable to find in my local env...
@Devportobello Personally, I do it as follows:
- update information about state of joomla remote - git fetch joomla
- switch branch to staging - git checkout staging
- rebase local staging to remote - git rebase joomla/staging
- push to my github - git push
- switch branch to PR branch - git checkout [PR_branch_name]
- rebase local PR branch to local staging - git rebase staging
at this point git report the first file with conflict and will mark the beginning of the conflict in the file as <<<<<<< HEAD
| Category | Administration Components Language & Strings | ⇒ | Repository Unit Tests Administration Components SQL Postgresql MS SQL |
T_T total fail...
| Labels |
Added:
?
|
||
| Category | Administration Components Repository Unit Tests SQL Postgresql MS SQL | ⇒ | Administration Components Language & Strings |
@Devportobello it seems ok now!
@jeckodevelopment yes, and i dont understand why xD (was tryharding on rebase but finally just a merge got it ...)
So it needs to be tested now
Any milestone ?
@Devportobello we typically only add a milestone when it is ready to commit (unless it is specifically not for the next release)
| Category | Administration Components Language & Strings | ⇒ | Administration com_menus com_modules Language & Strings Components |
Conflicts resolved !
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11999.
One more test to hope J3.7
Near 1 year, maybe not really usefull... close
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-12 08:54:54 |
| Closed_By | ⇒ | Devportobello |
This PR breaks the module manager
when you open a module you get
"Error: 0 Error decoding JSON data: Syntax error"