[#11930] - [installation] Improve ajax error treatment
- Closed
- 2 Jan 2017
- Medium
- Build: staging
- # 11930
- Diff
- andrepereiradasilva:installation-error-catch
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
There are some parts of the installation process that don't check for ajax request issues (timeout, syntax error, server error codes, etc) leaving the user with no clue on what is wrong.
This PR corrects that and also improves the error messages by replacing javascript alert messages with joomla message errors.
Didn't change the ftp part because don't have way to test it
Testing Instructions
- First apply this patch
- Delete configuration.php and reload any site page you'll be redirect to installation
- When in installation view: Clear all browser cache
- Test no regresssions: normal installations and check everything is fine
- Repeat step 2.
- Test forcing errors, for checking you always get some error message:
- Add an sql error in joomla.sql file. Try to install, you should get an error
- Add some non php text (anything that generates a php syntax error) inside
/installation/model/configuration.php. Try to install, you should get an error - Rename
/installation/controller/site.phpto anything. Try to install, you should get an error - Throw some exception (example:
throw new Exception('some error', 404);) here https://github.com/joomla/joomla-cms/blob/staging/installation/controller/site.php#L34 . Try to install, you should get an error - Test forcing any other error you can remember in the install process
- Code review. Use this to ignore whitespaces changes https://github.com/joomla/joomla-cms/pull/11930/files?w=1
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
| Labels |
Added:
?
|
||
That's why i said (the problem is this file didn't use tabs for indent as all other joomla files. i corrected that also)
Code review. Use this to ignore whitespaces changes https://github.com/joomla/joomla-cms/pull/11930/files?w=1
closing because lack of interrest
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-02 15:45:16 |
| Closed_By | ⇒ | andrepereiradasilva |
It's really hard to see scope of changes when you've changed whitespace formatting.