@brianteeman @infograf768 is it what you asked in #10996?

@fedik yes - that looks very interesting.

Couple of quick observations.
1. You can create a toolbar wider than the allowed area - in fact some of the samples are
2. I think you need some more contrast between the drop areas. I couldnt work out why my icons weren't "dropping" until I saw that the top row is only for the dropdown menus.

I like this approach, user (very) friendly

make a "Presets" so user can set access level for each "Preset"

Good news!

?
But I do not quite understand the approach.
I would prefer a couple of presets (3 or create more) that I can modify and assign to user groups (users?). Alternatively different setup for back- and frontend.
Hmm... I have no clou why the current advanced settings use view levels. Since J 1.5?

I do not understand the use of the three buttons simple/advanced/clear.

Bug: I do not see any separators after applying a new setting. That might be one source of the width problem.

The user groups ("view levels") should better be in a drop down and not tabs. The list can be long.

A good start!

I do not understand the use of the three buttons simple/advanced/clear.
They are the presets you requested

On 6 September 2016 at 12:56, Ove Eriksson notifications@github.com wrote:

?
But I do not quite understand the approach.
I would prefer a couple of presets (3 or create more) that I can modify
and assign to user groups (users?). Alternatively different setup for back-
and frontend.
Hmm... I have no clou why the current advanced settings use view levels.
Since J 1.5?

I do not understand the use of the three buttons simple/advanced/clear.

Bug: I do not see any separators after applying a new setting. That might
be one source of the width problem.

The user groups ("view levels") should better be in a drop down and not
tabs. The list can be long.

A good start!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11926 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VkBh0XI6C2TUTgQON2Z95OcLaOJks5qnVTvgaJpZM4J0kpq
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

The user groups ("view levels") should better be in a drop down and not tabs.

for now, each tab is a separated form for selected View level

I would prefer a couple of presets (3 or create more) that I can modify and assign to user

something similar already planed for future changes, as I wrote in p.s. ?

There will not often be a need of more then 2 or three different settings. If the 3 presets used currently, simple, advanced and extended ( =all? ) are loaded by default they can be edited and assigned to user groups. The B/C problem I see are the view level settings for the "extended" settings.

Use old handling until new parameters get saved?

I like the new changes to have sets and not usergroups in the tabs. I assume its a bug that they are ordered
Set 2, Set 1, Set 0
and not
Set 0, Set 1, Set 2

Doesnt it mean that the level select dropdown needs to be a multiselect? How else can you apply Set 2 to multiple groups - maybe I am missing something

Set 2, Set 1, Set 0

It made with purpose.
Where on clear installation we get:
0 - for advanced
1 - for medium
2 and all other which added by user will use Simple preset for initial state.

So when you set "Set amount" to 5: you will get: 4 3 2 1 0.
Where 4 3 will be new Sets and they will be in "first tabs".
I thought it can be more intuitive, mean more easy to find new. Also I thought In most cases user will want to edit 1 and 2, so I put it on front.

How else can you apply Set 2 to multiple groups

hm, but with other content we have the same. You can chose only one access level for Article, Module etc. and each access level have some inheritance , should be no problem.

other thing: it can be hard to implement ?
and as you can have unlimited Sets (by default 3), you can make a Set for each access level

I missed the "amount of sets" option on the advanced tab ;)

On 11 September 2016 at 10:56, Fedir Zinchuk notifications@github.com
wrote:

Set 2, Set 1, Set 0

It made with purpose.
Where on clear installation we get:
0 - for advanced
1 - for medium
2 and all other which added by user will use Simple preset for initial
state.

So when you set "Set amount" to 5: you will get: 4 3 2 1 0.
Where 4 3 will be new Sets and they will be in "first tabs".
I thought it can be more intuitive, mean more easy to find new.

Also I thought In most cases user will want to edit 1 and 2, so I put it
on front.

How else can you apply Set 2 to multiple groups

hm, but with other content we have the same. You can chose only one access
level for Article, Module etc. and each access level have some inheritance
, should be no problem.

other thing: it can be hard to implement ?
and as you can have unlimited Sets (by default 3), you can make a Set for
each access level

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11926 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Zo-C1NC0n5o-yfguKQlM2xYwiLCks5qo9BIgaJpZM4J0kpq
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I need small help here.
I made 3 presets: Simple, Medium, Advanced.

Would be cool if someone will improve them, and make it more real for what user needs.
It is easy to edit, just add needed buttons in: https://github.com/Fedik/joomla-cms/blob/0b4d803c35c3995934b017f74496d0c3c26f8bb0/plugins/editors/tinymce/tinymce.php#L1064-L1106

For B/C don't you think the presets should match the current sets

On 11 September 2016 at 11:03, Fedir Zinchuk notifications@github.com
wrote:

I need small help here.
I made 3 presets: Simple, Medium, Advanced.

Would be cool if someone will improve them, and make it more real for what
user needs.
It is easy to edit, just add needed buttons in: https://github.com/Fedik/
joomla-cms/blob/0b4d803c35c3995934b017f74496d0c3c26f8bb0/plugins/editors/
tinymce/tinymce.php#L1064-L1106

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11926 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TEaeH41DlBpqrPlqqxP4aOdnla6ks5qo9HpgaJpZM4J0kpq
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

yes, this would be cool. But there no simple way to find out what was in old ?
that why I asked for help ?

Advanced preset I tried to make similar to what we had with Advanced mode (when all plugin is ON),
But the Medium preset is totally random stuff for now.
And Simple preset, also tried to copy, but it looks tooooo simple ?

And on clear installation/after upgrade will be:
Advanced => for Special access level
Medium => for Registered
Simple => for everyone else

I have update the pull description, with more detailed info about how it work.
I think it is ready for testing, to find out what can be improved and how it will work in real life ?

And would be cool to see this feature in 3.7

I have updated the presets, so they now look more close to what we have now.

Simple

Medium

Advanced

Great. Thanks.

As you can see from the screenshot I dont get the exact same layout as you with the Advanced preset

The same thing happens with the Medium preset. There is a new line after the fourth icon and the whole toolbar is wider than the available area

Tested with 3.7

I have tested this item ? unsuccessfully on 58eb3bd

please, can someone change destination branch from staging => 3.7.x?
it will be more easy to test and fix possible conflicts, also #11157 already merged there

Done. You can also do it your self via the edit button where you edit the PR title ;)

@zero-24 thanks!

@brianteeman fixed

@Fedik this will be compatible with #11367 ??
Also any help on that one would be appreciated ?

@Fedik thanks - will test soon. As you can tell I am super excited about this PR

@dgt41 will be a loot conflicts for sure ?
but in final all should be compatible, after some modification,

and to be honest I not very understand what there is going on ?

@fedik - thanks I can confirm that issue is fixed

I have tested this item ✅ successfully on 58eb3bd

test fail on unrelated test, something with Highlight testing

@fedik can you fix the merge conflicts please

@all this is an absolute killer feature PLEASE can people test it. I have been using it myself developing a site and it rocks. At least one less extension to install

@fedik the drone tests should pass if we sync to staging :)

fixed

Great. Thanks. I will try to get more testers for this as I really want to
see this in core.

One question:
what happens when a user group has multiple viewing access?

Example:

Will managers get the Special access setting or one of the others (Registered, Customer Access Level)?

it will take higher, or last in the order https://github.com/Fedik/joomla-cms/blob/e5cc7cc45e75156e331979f84463cf79ee17dc8c/plugins/editors/tinymce/tinymce.php#L174

Alternatively and If you are using a flat acl because you are doing role based acl you can also just create new editor groups. Basic editor, advanced editor etc

it will take higher, or last in the order

Does that mean that in the case above, Managers would get the Special access setting?

it will take the last one from the array of the user view levels, that come from $user->getAuthorisedViewLevels()
so it will depend from the ordering, for your example

I have tested this item ✅ successfully on 58eb3bd

Thank you @Fedik
RTC

@Fedik
REGRESSION: Looks like this broke automatic language detection
See #13343
also see
#13344