Joomla! Issue Tracker | Joomla! CMS #11859 - Added "collapsed" to closed slides accordion-toggle class

?

Fixed in Code Base
2 Sep 2016
Medium
Build: staging
# 11859
Diff
Minei3oat:staging

Success

Success continuous-integration/drone the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

Minei3oat
31 Aug 2016

Pull Request for Issue # .

Summary of Changes

Added "collapsed" to closed slides accordion-toggle class. This class is added by Javascript during user-interaction when a slide closes and removed when it opens:
https://github.com/joomla/joomla-cms/blob/staging/media/jui/js/bootstrap.js#L630-L641

It could be used by templates for different styling of the title of closed/opend slides which requires this class when the page is loaded. If it is not added by PHP, the templates must add it self with Javascript during page load.

Testing Instructions

Create Slides (open and closed) and look at the class of the slides title (accordion-toggle)

Documentation Changes Required

4c8398b 31 Aug 2016

Added "collapsed" to closed slides accordion-toggle class

Minei3oat - open - 31 Aug 2016

Minei3oat - change - 31 Aug 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 31 Aug 2016

Labels

Added: ?

joomla-cms-bot - change - 31 Aug 2016

Category

⇒

Libraries

Bakual - test_item - 31 Aug 2016 - Tested successfully

Bakual - comment - 31 Aug 2016

I have tested this item ✅ successfully on 4c8398b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

bhavikTailored - comment - 1 Sep 2016

Hello @Minei3oat,

Can you give me screenshot or elaborate so I can test this issue.

Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

zero-24 - comment - 1 Sep 2016

@bhavikTailored

Do you mean something like this:

There @bakual hand included a screenshot for the exact same code ;)

bhavikTailored - comment - 1 Sep 2016

Thanks @Bakual, Now I got it.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

bhavikTailored - comment - 1 Sep 2016

I have tested successfully.
_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

bhavikTailored - test_item - 1 Sep 2016 - Tested successfully

bhavikTailored - comment - 1 Sep 2016

I have tested this item ✅ successfully on 4c8398b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

BhaveshTailored - test_item - 2 Sep 2016 - Tested successfully

BhaveshTailored - comment - 2 Sep 2016

I have tested this item ✅ successfully on 4c8398b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

brianteeman - change - 2 Sep 2016

Status

Pending

⇒

Ready to Commit

brianteeman - comment - 2 Sep 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

joomla-cms-bot - change - 2 Sep 2016

Labels

Added: ?

rdeutz - change - 2 Sep 2016

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-09-02 08:01:07
Closed_By		⇒	rdeutz

rdeutz - close - 2 Sep 2016

rdeutz - merge - 2 Sep 2016

joomla-cms-bot - close - 2 Sep 2016

joomla-cms-bot - change - 2 Sep 2016

Labels

Removed: ?

tomartailored - test_item - 6 Sep 2016 - Tested successfully

tomartailored - comment - 6 Sep 2016

I have tested this item ✅ successfully on 4c8398b

I have tested successfully

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11859.}

Add a Comment

Login with GitHub to post a comment

Older
Newer