Feeling Lucky
?
[#11860] - MSSQL: use error code instead of SQLSTATE
- Fixed in Code Base
- 31 Aug 2016
- Medium
- Build: staging
- # 11860
- Diff
- williamsandy:staging
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
Pull Request for
# 11280
User tests: Successful: Unsuccessful:
Change to use native error code for exceptions instead of the driver specific SQLSTATE value because this value is not always am integer
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
mbabker
- comment
- 31 Aug 2016
Based on the PHP documentation this looks fine to me. Don't have a Windows box to test this against though.
| Rel_Number | 0 | ⇒ | 11280 |
| Relation Type | ⇒ | Pull Request for |
waader
- comment
- 31 Aug 2016
I have tested this item
I could reproduce the problem described in #11280 and this patch resolves it. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11860.
alikon
- comment
- 31 Aug 2016
I have tested this item
on code review + for documentation
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11860.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 31 Aug 2016
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-31 19:58:10 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Created this PR for issue #11280
SQLSTATE as seen here it is not always a number MSDN article
So if you are passing the SQLSTATE value '42S22' for error 'Column not found', '42S01' for error 'Base table or view not found' or even 'HY000' for 'General error' into RuntimeException for the error code that will be problematic as it is expecting an integer.