[#11858] - [contact modal field] Adds Create Contact button and other improvements
- Closed
- 4 Sep 2016
- Medium
- Build: staging
- # 11858
- Diff
- andrepereiradasilva:new-contact
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 2 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR is the sequence of #11830 but for now for contact modal.
For list of changes see #11830 (same changes, but for contact now).
Similiar PR:
Animated Gif (click to view in full screen)
Testing Instructions
- Use latest staging
- Apply patch #11830 and then this patch
- Create a Menu item Single Contact type
- Test all the "Edit", "Create", "Select" and "Clear" buttons (as animated gif)
- In a multilanguage install edit a contact and try the modal button in the associations tab
- Test all the "Edit", "Create", "Select" and "Clear" buttons.
- Code review to check all is ok.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components Front End |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
The issue you describe have nothing to do with this pr.
This pr does not intend to solve the lack of responsive design in some backoffice Pages.
Só it all test is ok please Mark as success.
I have tested this item
Tested this PR successfully BUT the modal layout does need to be fixed before this can be accepted
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
@brianteeman , I agree with you. we should first fix layout then I will test successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
As said, that's a admin template responsible css issue (it will happen if you use those width sizes) that probably exists in several other places.
If someone wants to solve those css issues in the admin template in a new PR go ahead, but please don't hijack this PR.
So, again, if the rest is tested with success please mark tested with success!
@andrepereiradasilva I hear what you are saying but the layout issues must be resolved before this PR can be accepted so it would make sense to do it here
That bug ALREADY EXISTS in current staging modals, just:
- use latest staging without changes
- create a new item single contact type
- Save
- Now press the "Edit" button ...
as said, if anyone wants to solve responsive css design issues in the modals please go ahead and o PR for that.
but please don't do here!
Again that as nothing to do with this.
So, again, if the rest is tested with success please mark tested with success!
Looks good to me. I can't reproduce the problem?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
So RTC?
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC and creating a new issue for the modal
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 12:54:39 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11858.