[#11808] - WCAG (AAA) Compliance (Protostar - Part 1)
- Closed
- 30 Aug 2016
- Medium
- Build: staging
- # 11808
- Diff
- C-Lodder:wcag-aaa
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
I think it's time to start complying with level AAA of WCAG
Summary of Changes
This PR:
- Darkens the links colour to fix the contrast issues
- Replace the
href="#top"withhref="#"on the "Back to top" button, which stops trying to anchor to a non-existent element
Testing Instructions
Apply the patch.
Before:
After:
What next?
I'll start gradually going through Protostar to make, as much as I can (without destroying the UI), AAA compliant, and then Isis after that.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (site) Front End JavaScript |
I think I'm going to do this as separate PR's to prevent long discussions and timely decisions. To kick it off, I've addressed the contrast issues for normal and large text, so they comply with AAA standards (contrast ratio of 7:1), and the "back to top" button
I agree. Small will be easier to push through.
Good strategy! And thank you for taking care of these aspects! :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11808.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11808.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
thanks for testing
waiting for parts 2, 3, .... 99
On 30 August 2016 at 19:27, Lodder notifications@github.com wrote:
thanks for testing
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11808 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eVMJGhdH-dASUZkFQqCMjTj2b0iks5qlHYrgaJpZM4JuJ7E
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
hehe, I'm going to wait till some of the UI PR's are merged first (Isis), but will continue to work on protostar this week
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-30 19:40:58 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
So do you need more time to complete it?
Should we wait to start testing it?