? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
26 Aug 2016

Pull Request to replace #11753

Summary of Changes

This PR fixes the width for .row-striped .row-fluid { } and buckled rows on com_contact, without having to change the HTML markup

Testing Instructions

See here: #11753

Results

Before patch:
before

After patch:
after

avatar C-Lodder C-Lodder - open - 26 Aug 2016
avatar C-Lodder C-Lodder - change - 26 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Category Templates (admin) Administration Front End Components Templates (site)
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Labels Added: ?
avatar C-Lodder C-Lodder - edited - 26 Aug 2016
avatar C-Lodder C-Lodder - change - 26 Aug 2016
The description was changed
avatar C-Lodder C-Lodder - edited - 26 Aug 2016
avatar C-Lodder C-Lodder - edited - 26 Aug 2016
avatar C-Lodder C-Lodder - change - 26 Aug 2016
The description was changed
avatar C-Lodder C-Lodder - edited - 26 Aug 2016
avatar nvyush
nvyush - comment - 26 Aug 2016

@C-Lodder I found two files more: '/media/jui/css/bootstrap-extended.css' and '/media/jui/less/bootstrap-extended.less'

Could you add some improvement to '/components/com_contact/views/category/tmpl/default_items.php' from my version - sizing of span / lines with $contact_width variable? Then I close my PR.

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

I'll add the $contact_width but I'm not going to update the bootstrap LESS file. That's why I manually added it to the protostar.less ;)

avatar nvyush
nvyush - comment - 26 Aug 2016

I have tested this item successfully on ac8a8e9.

I downloaded the current native bootstrap v 3.7.7. It doesn't contain 'bootstrap-extended.less' file and doesn't contain any .ss file with 97%. I think files'/media/jui/css/bootstrap-extended.css' and '/media/jui/less/bootstrap-extended.less' could be modified also.

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

@dgt41 ?

avatar mbabker
mbabker - comment - 26 Aug 2016

It doesn't contain 'bootstrap-extended.less' file

Because that's Joomla's custom addons to the core Bootstrap LESS.

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

@nvyush - Moved the Protostar LESS changes to bootstrap-extended.less

avatar dgt41 dgt41 - test_item - 26 Aug 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 26 Aug 2016

I have tested this item successfully on ae41b79


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11807.

avatar dgt41
dgt41 - comment - 26 Aug 2016

@C-Lodder can you re-run generates.php?

avatar nvyush
nvyush - comment - 26 Aug 2016

I have tested this item successfully on ae41b79

avatar C-Lodder
C-Lodder - comment - 26 Aug 2016

@dgt41 oops, done

avatar nvyush
nvyush - comment - 26 Aug 2016

I have tested this item successfully on ea9e020

avatar brianteeman brianteeman - change - 26 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 26 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11807.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Aug 2016
avatar rdeutz rdeutz - merge - 27 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Aug 2016
avatar rdeutz rdeutz - change - 27 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-27 18:12:07
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment