? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
22 Aug 2016

Summary of Changes

Normalizes all sql azure joomla install file.

  • always use SET IDENTITY_INSERT [#__xxxx] ON/OFF;
  • INSERT to INSERT INTO
  • Quote all table names and db field names
  • Always use ' to quote string values.
  • Code style

Testing Instructions

Mainly code review. (to many changes need to check code in raw)
https://github.com/andrepereiradasilva/joomla-cms/blob/sqlazure-sample-blog/installation/sql/sqlazure/sample_blog.sql
If anyone could test an install 3.6.x would be great. Don't have sql azure to test,

Documentation Changes Required

None.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Category Installation SQL MS SQL
avatar andrepereiradasilva andrepereiradasilva - open - 22 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 22 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 22 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 22 Aug 2016
avatar alikon alikon - test_item - 23 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 23 Aug 2016

I have tested this item successfully on 6bbeaa1

on code review still unable to test on MSSQL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11726.

avatar waader waader - test_item - 23 Aug 2016 - Not tested
avatar waader
waader - comment - 23 Aug 2016

I have not tested this item.

I get this error:

[Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'UNION'. SQL=INSERT INTO #__categories UNION ALL SELECT 1, 0, 0, 0, 17, 0, '', 'system', 'ROOT', 'root', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{}', '', '', '', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 2, 27, 1, 1, 2, 1, 'uncategorised', 'com_content', 'Uncategorised', 'uncategorised', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"target":"","image":""}', '', '', '{"page_title":"","author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 3, 28, 1, 3, 4, 1, 'uncategorised', 'com_banners', 'Uncategorised', 'uncategorised', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"target":"","image":"","foobar":""}', '', '', '{"page_title":"","author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 4, 29, 1, 5, 6, 1, 'uncategorised', 'com_contact', 'Uncategorised', 'uncategorised', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"target":"","image":""}', '', '', '{"page_title":"","author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 5, 30, 1, 7, 8, 1, 'uncategorised', 'com_newsfeeds', 'Uncategorised', 'uncategorised', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"target":"","image":""}', '', '', '{"page_title":"","author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 7, 32, 1, 11, 12, 1, 'uncategorised', 'com_users', 'Uncategorised', 'uncategorised', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"target":"","image":""}', '', '', '{"page_title":"","author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '', 1 UNION ALL SELECT 9, 35, 1, 15, 16, 1, 'blog', 'com_content', 'Blog', 'blog', '', '', 1, 0, '1900-01-01 00:00:00', 1, '{"category_layout":"","image":""}', '', '', '{"author":"","robots":""}', 628, '2011-01-01 00:00:00', 0, '1900-01-01 00:00:00', 0, '*', 1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11726.

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Aug 2016

fixed, can you test again?

avatar waader waader - test_item - 23 Aug 2016 - Tested successfully
avatar waader
waader - comment - 23 Aug 2016

I have tested this item successfully on 1ab684e

Works now, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11726.

avatar brianteeman brianteeman - change - 23 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11726.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 24 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-24 22:13:43
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Aug 2016
avatar wilsonge wilsonge - merge - 24 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 24 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment