I have tested this item ✅ successfully on d4b33d0

on code review still unable to test on MSSQL

I have not tested this item.

I get this error message when installing additional languages:

[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla35.dbo.#__extensions'; column does not allow nulls. INSERT fails. SQL=INSERT INTO #__extensions VALUES ('EnglishAustralia','language','en-AU','','1','1','0','0','{"name":"English (Australia)","type":"language","creationDate":"August 2016","author":"stevec4","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"stevec4@comcast.net","authorUrl":"www.joomla.org","version":"3.6.2.2","description":"en-AU administrator language","group":"","filename":"install"}','{}')
[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla35.dbo.#__extensions'; column does not allow nulls. INSERT fails. SQL=INSERT INTO #__extensions VALUES ('Belarusian','language','be-BY','','0','1','0','0','{"name":"Belarusian","type":"language","creationDate":"2012-11-20","author":"Dennis Hermatski","copyright":"Copyright (C) 2005 - 2012 Open Source Matters. All rights reserved","authorEmail":"sirdionisiy@gmail.com","authorUrl":"www.joomla.com","version":"3.0.2","description":"be-BY site language","group":"","filename":"install"}','{}')
[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla35.dbo.#__extensions'; column does not allow nulls. INSERT fails. SQL=INSERT INTO #__extensions VALUES ('Basque','language','eu-ES','','0','1','0','0','{"name":"Basque","type":"language","creationDate":"August 2016","author":"Joomla! Basque Translation Team","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"joomlaeuskaraz@gmail.com","authorUrl":"","version":"3.6.2.1","description":"eu-ES site language","group":"","filename":"install"}','{}')

This does not seems related to this PR.
This PR does not changes that, you probably already have that issue before thsi PR.

So you probably can't install any language right? even in backend "Install languages" right?

[Microsoft][SQL Server Native Client 11.0][SQL Server]
Cannot insert the value NULL into column 'custom_data', table 'joomla35.dbo.#__extensions';
column does not allow nulls.

INTO #__extensions VALUES ('EnglishAustralia','language','en-AU','','1','1','0','0','{"name":"English (Australia)","type":"language","creationDate":"August 2016","author":"stevec4","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"stevec4@comcast.net","authorUrl":"www.joomla.org","version":"3.6.2.2","description":"en-AU administrator language","group":"","filename":"install"}','{}')

@alikon any idea why this happens?

I have tested this item ✅ successfully on d4b33d0

You are right! This problem existed already.

RTC

@andrepereiradasilva MSSQL is right
the extensions table field
[custom_data] [nvarchar](max) NOT NULL,
is declared NOT NULL but without default

so we need to provide a value to that field as it is now in sql script nothing is provided for that field

ok so i added the default value
b875501

because it exists in joomla.sql in postgresql
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L460

@waader @alikon please check

You should add the usual alter table for the update too...

On 23 Aug 2016 3:34 pm, "andrepereiradasilva" notifications@github.com
wrote:

ok so i added the default value
b875501
b875501

because it exists in joomla.sql in postgresql
https://github.com/joomla/joomla-cms/blob/staging/
installation/sql/postgresql/joomla.sql#L460

@waader https://github.com/waader @alikon https://github.com/alikon
please check

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11725 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsfoD5ULt4H7cK7LnCUoSs1xO0CXdks5qivbbgaJpZM4JpxqF
.

ok so i reverted that change will wait for this to et merged and then will make a PR to put that right.

I only remind
[custom_data] [nvarchar](max) NOT NULL, still does not have DEFAULT ''