[#11718] - Improvement: Adding the forced language in the modal title for Contacts and Newsfeeds
- Fixed in Code Base
- 24 Aug 2016
- Medium
- Build: staging
- # 11718
- Diff
- infograf768:forcedlanguage_modal
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
To test on a multingual site.
When using associations and selecting a News Feed or a Contact, the language title is appended to the Modal title.
After patch:
This PR also normalizes some language string.
See also for categories #11717
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Aside from the successful test, it would look a lot better like this, since the language is always the same, there is a useless column there, in this mockup I've removed it and added the language with a flag bellow, see what you think, if it's not worth the effort nvm :)
Imho, the column is still useful. A confirmation of the language used.
Also, when we are not in forcedlanguage (associations), we do need it.
Example:
seems all fine, except the possible RTL issue.
Replied concerning the rtl in the other PR
Can you mark the test OK?
When you create a multilingual joomla website from the installer the content languages are all created in the form
French (FR)
English (United States)
Danish (da-DK)
English (UK)
Which means that you now have nested brackets like
Select or Change Contact (English (UK))
To avoid that I would just remove the bracket and have a dash between the string and the language
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.
@infograf768 can you remove brackets? After that we can change this to RTC.
Parenthesis replaced by mdash. Here in RTL
| Status | Pending | ⇒ | Ready to Commit |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.
| Labels |
Added:
?
|
||
Thank you @infograf768
On 22 August 2016 at 14:45, andrepereiradasilva notifications@github.com
wrote:
I have tested this item
✅ successfully on 33d713a33d713a
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11718
https://issues.joomla.org/tracker/joomla-cms/11718.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11718 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8X1QKqoBxp40wu_3E9hvo6Wnu54Kks5qiafegaJpZM4Jpklu
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-24 07:09:02 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 3b7a5e2
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11718.