[#11719] - [com_contact] Move event trigger to correct place
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11719
- Diff
- nvyush:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
1) Event trigger of the event afterDisplayTitle is in the wrong place — when option 'show_contact_category' is 'show_with_link' it triggers BEFORE of displaying the title.
2) The option 'show_contact_category' can't be simultaneously 'show_no_link' and 'show_with_link', two if replaced with if - elseif.
Testing Instructions
1) Create a test contact.
2) Create test contact category, place test contacts to it.
3) Create test menu item of type 'Contacts' - 'Single Contact' for the test contact.
4) Set option 'Contact Display Options' - 'Contact Category' of the test menu item to value 'Show Without Link'. There must be no difference for page of test contact.
5) Set option 'Contact Display Options' - 'Contact Category' of the test menu item to value 'Show With Link'. There must be no difference for page of test contact unless you use event afterDisplayTitle.
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Tested as per Instructions.
I have attached two screen shots.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11719.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11719.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 20:31:43 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on be99007
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11719.