[#11717] - Improvement: Using modal_category field in various core locations
- Closed
- 28 Aug 2016
- Medium
- Build: staging
- # 11717
- Diff
- infograf768:category_modals
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR lets use the existing modal_category field when possible in core, which is quite handy when one has many categories to deal with:
Menu items:
List Contacts in a Category
Content Category blog
Content Category list
List Newsfeeds in a category
Also:
User Notes
mod_articles categories
Example:
It also adds in multilingual associations the forcedlanguage in the title of the Select or Change Category modal.
Example, from the already existing:
we get when using the Select button:
This can go in 3.6.3 as it is not a new feature (contrary to #11694 which depends on the new modal_menu fields already merged in 3.7.0).
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings Front End Modules |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
besides the comment above all seems to work fine
RTL looks fine here:
Can you mark the test OK?
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.
Same comment as in the other PR regarding the use of the brackets
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.
@infograf768 same here. Remove brackets and it goes to RTC
Parenthesis replaced by mdash
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Thank you @infograf768
On 22 August 2016 at 14:44, infograf768 notifications@github.com wrote:
RTC
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11717
https://issues.joomla.org/tracker/joomla-cms/11717.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11717 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b8xZFlfgsy4ix3ob-uaJlOPnmCBks5qiae4gaJpZM4JpizU
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I agree with the 3.7.0 milestone setting, this here is changing the UI/UX the other PRs are only changing text.
In this case, I am ready to modify this PR and only change the modal title without touching at the xmls for now.
@infograf768 sounds good
Took off the changes in the modal and will make a new PR with these only in order to get the modal title change in 3.6.3.
This can remain as is now for 3.7.0
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-28 20:34:12 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 1183afc
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717.