[#11716] - [com_banners] - reduce the number of executed query
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11716
- Diff
- alikon:patch-77
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11701 .
Summary of Changes
- reduced the number of executed queries for impression as suggested by @mengqigu
- reduced the number of executed queries in case of already tracked items
- used
JDatabaseExceptionExecutinginstead ofRuntimeException
Testing Instructions
with the debug plugin enabled
test the banners modules you'll should notice less number of exectuted queries
see #11701
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Reggarding the patch itself i noticed a sligh improvement (used 5 banners) in performance and memory consumption.
Before
After
Anyway this module is still the modules that takes more time to load (in the ones that i have).
Even with this patch, on my test site server (no php/joomla caching, joomla debug mode on), this module is still the module that takes more time to load (in the ones that i have). For reference:
I have tested this item
performance improved.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11716.
interresting ... while testing this i discovered this query ...
yes indeed room for a new PR, still need to understand how Purchase Type is supposed to work....
i don't use banners at all ;)
@alikon there are better things to spend your time on
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11716.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11716.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 20:04:18 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
interresting ... while testing this i discovered this query ...