[#11715] - Handle the case that JFolder::files returns 'false'
- Fixed in Code Base
- 29 Apr 2018
- Medium
- Build: staging
- # 11715
- Diff
- okonomiyaki3000:installer-bug
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Basically, check that we actually got a list of files before trying to work on it as an array.
JFolder::files() may return false in some cases. So we need to check that before using its response as an array.
Testing Instructions
To expose the error, I guess you need to install an extension whose manifest file specifies a schemapath which does not exist. So, yes, this bug only really shows up when the extension to be installed has something wrong with it. What will happen is that JFolder::files() will return false which is passed to str_replace. I'm not sure what gets returned at that point but it's definitely not an array as expected. That return value will be passed to usort, count, foreach, and end as if it were an array. These will generate warnings.
After applying this fix, the function should exit when JFolder::files() return false or empty array. No warnings.
Documentation Changes Required
Nope.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@okonomiyaki3000 can you please solve conflicting Files?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11715.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11715.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-29 14:50:57 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 69223ed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11715.