[#11691] - Always set all columns from app's checkSession method
- Fixed in Code Base
- 21 Aug 2016
- Medium
- Build: staging
- # 11691
- Diff
- mbabker:set-all-session-columns
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JApplicationCms::checkSession() tries to micro optimize the INSERT query it runs if creating a record in the #__session table by checking if the session is new. Honestly, there isn't a pressing need to do this though; the only column value that is different between the two steps of the conditional is the time column. So, only have a conditional on this value and have the query always insert the full data set.
As an added bonus, uses of the deprecated JObject API are removed from pulling data from the JUser object.
Additionally, the query's columns and values are moved out from hard-to-read inline values to arrays that are handled when calling the query builder's API methods.
Testing Instructions
This might fix #11556 so however folks are reproducing that issue. Otherwise, this is mainly review and make sure the CMS still works (if it fails it'll fail very quickly because it's called very early in the request cycle).
Documentation Changes Required
N/A
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Thanks!
I have also tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11691.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on testing. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11691.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-21 16:12:43 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 1ddfc4f
I tested this mainly for #11556 and now sessions seem to be correct again (for Kunena in my case)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11691.