[#11692] - New method for retrieving the strings from the store
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 11692
- Diff
- mbabker:JText-script-split
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JText::script() violates SRP by acting as a setter and getter for the internal storage array of strings for use with JavaScript. This PR deprecates the getter portion of this method in favor of a new API method to get these strings and will raise a deprecation notice when the current getter behavior is used.
At 4.0, JText::script() will have its method signature changed to require a string is always passed and will only act as a setter for the storage array.
Testing Instructions
Uses of JText::script() with no parameters should cause a deprecation message to be logged. The new JText::getScriptStrings() should return the contents of the internal storage array.
Documentation Changes Required
N/A, JText::script() is only documented via the automatically generated API documentation.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Intentional?
Nope, fixed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11692.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11692.
| Status | Pending | ⇒ | Ready to Commit |
@joomla-cms-bot please double check this one.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11692.
| Labels |
Added:
?
|
||
rdeutz
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 11:28:29 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@mbabker
Works as described.
I found the log entry in
/administrator/logs/everything.phpbut not in/administrator/logs/deprecated.php. Intentional?