@Fedik when you extend / edit core.js etc. it would be great, if you could also adjust the JavaScript tests we have for it (and add new ones). Thank you! :-)

See the documentation for more details

@yvesh thanks for the link, I need to try

@Fedik an idea, not sure if i'm thinking this right: can't JText::script() proxy to JDocument::addScriptOptions?

adding for instance:

$doc->addScriptOptions('joomla.text', $textVarsArray);

The Joomla.JText would get the text strings from the script options.

It seans like we have some duplicated code betwen JText and ScriptOptions as it is.

@andrepereiradasilva I think it is a good idea, I will try to make it in this way,
maybe use joomla.language? but joomla.text also sounds good

I not sure about proxy, but we can add it before scriptOptions rendering

what i mean by proxying is replacing this line (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/text.php#L386) by

$string= array(strtoupper($string) => JFactory::getLanguage()->_($string, $jsSafe, $interpretBackSlashes));
JFactory::getDocument()->addScriptOptions('joomla.text', $string);

(but, not sure if it's B/C)

@andrepereiradasilva it seems good, thanks for idea, I have updated the pull request

And now the pull request depends from #11671,
It still can be tested stand alone, but #11671 should be merged first

I have tested this item ✅ successfully on b83b6bd

Works as described. Also tested js error messages in SendTestMail.
Teste in Chrome, IE11, and IE10 Emulation Mode, IE9 Emulation Mode, IE8 Emulation Mode

Not sure I understand the test instructions as both before and after the PR I get the same

@brianteeman it means all works as expected ?

only question, you have placed alert() inside jQuery().ready() or on top of the file?

not sure where I put it now - i think it was before line 224 - but there is no Query().ready() in that file

if you try to place it on top of the file, then before the patch you should get: JavaScript error or string not found!!!

It not a bug, just to spot the difference

I have tested this item ✅ successfully on d305e26

I have tested this item ✅ successfully on d305e26

RTC. Thanks

@committer please double check that #11671 is merged before

@zero-24 you'd better go and test #11671 then ;)

if current pull is success then that pull is success also, because all important commits from that pull also is here

I just want to make sure that this one don't get missed:

the pull request depends from #11671,
It still can be tested stand alone, but #11671 should be merged first

@Fedik you should look if 45164a4 recent merge on 3.7.x branch does not have impact here.

@andrepereiradasilva because it was merged to 3.7 and the pull against staging ?

@andrepereiradasilva sorry I wrong understood you,
no it do not have imact here, only thing I added there is https://github.com/Fedik/joomla-cms/blob/d305e2682e96c0f9f5a4c303980e54472efd3fd8/libraries/joomla/language/text.php#L392
JFactory::getDocument()->addScriptOptions('joomla.jtext', self::$strings, false);

oh, wait, seems need to change self:: to static::
I will update it soon

Merged with 5e54494 :) Thanks and also thanks for the docs!