? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
4 Aug 2016

Pull Request for Issue #11309

Summary of Changes

This PR fixes the colour input fields in repeatable form fields. Reason being is the input fields needed to be properly destroyed and re-initiated, which they weren't

Testing Instructions

Add the following repeatable form field to (for example) the mod_login.xml file:

<field name="j51_inlineicons"
    type="Repeatable"
    select="List/Add Icons(s)"
    icon="list"
    description="Icons(s)"
    label="Icons(s)">
    <fields name="params">
    <fieldset hidden="true" name="j51_inlineicons_modal" repeat="true">
        <field name="j51_iconclass" type="text" default="" label="FontAwesome Icon Class" description="Set your FontAwesome Icon class name" />
        <field name="j51_icontitle" type="text" default="" label="Icon Title" description="Set your icon title" />
        <field name="j51_iconurl" type="text" default="" label="Icon URL" description="Set your linked icon URL" directory="/" filter="" exclude="" stripext="" />
        <field name="j51_iconcolor" type="color" default="#adb3b8" label="Icon Color" description="Set your icon colors" />
    </fieldset>
    </fields>
</field>

Then in the Module Manager, open the Login module, then open the repeatable form field.

Before patch:

before

After patch:

after

avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2016
Category JavaScript
avatar C-Lodder C-Lodder - open - 4 Aug 2016
avatar C-Lodder C-Lodder - change - 4 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2016
Labels Added: ?
avatar wilsonge wilsonge - test_item - 4 Aug 2016 - Tested successfully
avatar wilsonge
wilsonge - comment - 4 Aug 2016

I have tested this item successfully on 9c10463

PR worked as described for me - before the js was dodgy and the input field misplaced. Both fixed after applying the JS modification. Nice work!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11451.

avatar killoltailored killoltailored - test_item - 5 Aug 2016 - Tested successfully
avatar killoltailored
killoltailored - comment - 5 Aug 2016

I have tested this item successfully on 9c10463

Tested successfully with version Joomla! 3.6.3-dev Development [ Noether ] 5-August-2016 00:32 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11451.

avatar brianteeman brianteeman - change - 5 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11451.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2016
Labels Added: ?
avatar Fedik
Fedik - comment - 5 Aug 2016

@C-Lodder can you please do same for new field subform-repeatable.js#L219 ?

avatar C-Lodder
C-Lodder - comment - 5 Aug 2016

Applied fix to subforms-repeatable too

avatar ciar4n
ciar4n - comment - 7 Aug 2016

I have tested this item successfully

Excellent! Nicely done! Admittedly I was unable to replicate any issues with the new subforms repeatable before the patch but both working perfectly now.

avatar rdeutz rdeutz - change - 13 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 17:57:06
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Aug 2016
avatar rdeutz rdeutz - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment